surject: classify disjoint interval alignments - #4993
Open
Sagorikanag wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg surject -urelated changesDescription
Motivation
Interval discovery was conditional on supplementary reporting, coupling alignment
candidate generation to output selection. This separates those decisions and
classifies the resulting alignments according to their query overlap. Before, alignments
to distant but similar regions on the same path, such as segmental duplications
merged unless -u was used. When separated, every non-best alignment was labeled
supplementary, even if it covered the same part of the read and was really an alternative
mapping. Now, distant regions are always evaluated separately. A non-best alignment
overlapping the best by more than 4 bp of the read is secondary; a mostly disjoint alignment
is supplementary and emitted only with -u.