Bugfix for issue 22 - placeholder breaks on mobile - #24
Open
grwgreg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to change a few things to get this working.
The click event was being fired for the native select menu on both the initial opening of the select menu and also when an option was selected. This would call the triggerSod method, which didn't handle the toggling of the placeholder for touch devices. So I added some conditional checks for whether the select was being opened or closed on a touch device, toggling a new data variable $sod.data('touch_open') instead of the "open" class (which we don't want added on mobile devices).
Also, the blurSod method would then reset the placeholder to the wrong value on blur, based on which .sod_option had the selected class. To fix this I added some code to the selectChange method, setting the "selected" class on the right .sod_option element even though it isn't visible for mobile devices.
This seemed to fix it! 👯
Also updated the version number, date & reminified the file.