Prevent use of fmt for log messages without arguments - #403
Merged
Conversation
KonradBreitsprecherBkd
commented
Jul 30, 2026
KonradBreitsprecherBkd
commented
Contributor
- Add overload for string only logs without args
- Add ITest
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
MariusBgm
approved these changes
Jul 30, 2026
MariusBgm
left a comment
MariusBgm
left a comment
Collaborator
There was a problem hiding this comment.
just some cosmetic nits on how the configuration is built.
I really dislike JSON for tests, the yaml version is way more readable
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
KonradBreitsprecherBkd
force-pushed
the
dev_fix-user-logging
branch
from
July 31, 2026 06:46
150b6d2 to
c7fc2af
Compare
Signed-off-by: KonradBreitsprecherBkd <117755498+KonradBreitsprecherBkd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.