Update India holidays: subdiv holidays improvement (Central and West region)

[ankushhKapoor]

Proposed change

Fix subdiv holidays of India (Central and West region).

Fixes -
Chhattisgrah
Dadra and Nagar Haveli and Daman and Diu
Goa
Gujarat
Madhya Pradesh
Maharashtra
Rajasthan

Resources:
Official Notices collection

Part of GSoC and #3382

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency update (version deprecation/pin/upgrade)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new holidays functionality in general)

Checklist

• I've read and followed the contributing guidelines.
• I've run make check locally; all checks and tests passed.

[cubic-dev-ai]

All reported issues were addressed across 14 files (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 11 files (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 11 files (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bb7dd5c) to head (7fbf039).

Additional details and impacted files

@@            Coverage Diff             @@
##               dev     #3709    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          329       329            
  Lines        19752     20001   +249     
  Branches      2501      2502     +1     
==========================================
+ Hits         19752     20001   +249     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cubic-dev-ai]

1 issue found across 13 files (changes from recent commits).

Confidence score: 2/5

• holidays/locale/en_US/LC_MESSAGES/IN.po removes the Gujarat Day translation while the holiday remains defined for Gujarat, causing the May 1 holiday name to lose its intended localized text; restore the translation entry or remove/update the corresponding holiday definition consistently.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="holidays/locale/en_US/LC_MESSAGES/IN.po">

<violation number="1" location="holidays/locale/en_US/LC_MESSAGES/IN.po:470">
P1: This diff removes the "Gujarat Day" translation entry along with the holiday itself. On dev, the Gujarat (GJ) subdivision observes May 1 as "Gujarat Day" (`self._add_holiday_may_1(tr("Gujarat Day"))` in `_populate_subdiv_gj_public_holidays`), but the PR head drops both that holiday and its IN.po entry. Gujarat is not one of the states listed in this PR (Chhattisgarh, DNH&DD, Goa, MP, Maharashtra, Rajasthan), and you noted the change was accidental during the dev-branch merge. Restore the IN.po `Gujarat Day` entry (and the `Gujarat Day` holiday in india.py)</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: This diff removes the "Gujarat Day" translation entry along with the holiday itself. On dev, the Gujarat (GJ) subdivision observes May 1 as "Gujarat Day" (self._add_holiday_may_1(tr("Gujarat Day")) in _populate_subdiv_gj_public_holidays), but the PR head drops both that holiday and its IN.po entry. Gujarat is not one of the states listed in this PR (Chhattisgarh, DNH&DD, Goa, MP, Maharashtra, Rajasthan), and you noted the change was accidental during the dev-branch merge. Restore the IN.po Gujarat Day entry (and the Gujarat Day holiday in india.py)

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At holidays/locale/en_US/LC_MESSAGES/IN.po, line 470:

<comment>This diff removes the "Gujarat Day" translation entry along with the holiday itself. On dev, the Gujarat (GJ) subdivision observes May 1 as "Gujarat Day" (`self._add_holiday_may_1(tr("Gujarat Day"))` in `_populate_subdiv_gj_public_holidays`), but the PR head drops both that holiday and its IN.po entry. Gujarat is not one of the states listed in this PR (Chhattisgarh, DNH&DD, Goa, MP, Maharashtra, Rajasthan), and you noted the change was accidental during the dev-branch merge. Restore the IN.po `Gujarat Day` entry (and the `Gujarat Day` holiday in india.py)</comment>

<file context>
@@ -472,7 +467,7 @@ msgstr "Samvatsari Day"
 #. Gujarati New Year.
 msgid "Vikram Samvat New Year"
-msgstr "Vikram Samvat New Year"
+msgstr "Gujarati New Year"
 
 #. Vassi Uttarayan.
</file context>

[sonarqubecloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

[KJhellico]

Single AI comment on the translation:

Janjatiya Gaurav Divas:
kn: ಆದಿವಾಸಿ ಗೌರವ ದಿನ
te: ఆదివాసీ గౌరవ దినోత్సవం
ml: ആദിവാസി അഭിമാന ദിനം
ta: பழங்குடியினர் பெருமை நாள்