Fix toggle lookup to respect component root - #6714
Open
arpitjain099 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Contributor
|
✅ All commits on this PR now have a verified signature. Thanks for making that change! |
ethangardner
added
the
Needs: Internal Response 🔴
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team - this updates toggle so it resolves aria-controls from the control root node instead of always using document.
That lets banner toggles work when banner.on(root) is used with a shadow root.
I also added a banner regression test that initializes inside a shadow root and verifies open/close behavior.
Closes #6244.