Skip to content

fix: race condition causing builds stuck queued #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreddedbacon merged 1 commit into from
May 18, 2026
Merged

fix: race condition causing builds stuck queued #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/controllers/v1beta2/build_qoshandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ func (r *LagoonBuildReconciler) processQueue(ctx context.Context, opLog logr.Log
} else {
// start the build pod immediately
var lagoonBuild lagooncrd.LagoonBuild
if err := r.Get(ctx, types.NamespacedName{Namespace: pBuild.Namespace, Name: startBuild}, &lagoonBuild); err != nil {
// Bypass controller-runtime read cache to avoid race condition where a build exists but
// has not been put in the cache yet.
if err := r.APIReader.Get(ctx, types.NamespacedName{Namespace: pBuild.Namespace, Name: startBuild}, &lagoonBuild); err != nil {
// An error here results in the build being stuck queued until remote-controller is restarted.
return err
}
if err := r.processBuild(ctx, opLog, lagoonBuild); err != nil {
Expand Down
Loading