setup_builder: wait for non-zero device size before formatting sticky disk - #118
Merged
Conversation
… disk Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
bruce-y
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a hot-attach race where
mkfs.ext4fails withDevice size reported to be zeroright after the sticky-disk response arrives (seen in the staging benchmark run: jobthrash-swarm-shared / round2 (pyjobs).The VM agent hydrates the sticky disk into a pre-attached drive and asks the hypervisor to raise a virtio config-change interrupt; the GetStickyDisk response can reach the runner before the guest kernel has processed that interrupt, so
/dev/vdbtransiently reports size 0. The same window exists on the direct rbd-nbd hot-patch path, so the fix is guest-side:Beyond the mkfs failure, formatting/probing a zero-size view could also misread a warm disk as unformatted, so gating all device access on a non-zero size is the safe ordering. Times out loudly after 10s (observed race window is sub-second).
dist/rebuilt.Link to Devin session: https://app.devin.ai/sessions/ba61e842e479410d95116fe1dfe77b0f
Requested by: @piob-io
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled. (Staging)