Ironing out the kinks - #89
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the Renovate schema pipeline by regenerating the Go schema types with more specific (non-interface{}) structures and by shifting tooling assumptions toward the Nix flake development environment.
Changes:
- Regenerated
pkg/renovate/zz_generated.schema.goto use typed element structs/enums (e.g.,ConfigCustomManagersElem) instead ofinterface{}/raw pointers in multiple places. - Updated schema tests to use the new generated types for
customManagersmarshalling. - Adjusted schema-generation tooling: Makefile now expects
go-jsonschemaandjqto be available externally (and adds them toflake.nixdevShell), plus a more robust jq filter script.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/renovate/zz_generated.schema.go | Regenerated schema models with more specific Go types and new helper type definitions. |
| pkg/renovate/schema_test.go | Updated test to construct CustomManagers using new generated element types/enums. |
| Makefile | Stops auto-building/downloading jq/go-jsonschema binaries; uses PATH tools instead for schema generation. |
| hack/renovate/delete-refs.jq | Replaces direct del expression with a walk-based filter to remove $ref == "#" under any properties. |
| flake.nix | Adds go-jsonschema and jq to the devShell inputs to support Makefile targets. |
| .versions/jq | Removes pinned jq version file. |
| .versions/go-jsonschema | Removes pinned go-jsonschema version file. |
| .gitignore | Ignores .claude/*. |
Files not reviewed (1)
- pkg/renovate/zz_generated.schema.go: Generated file
Comments suppressed due to low confidence (1)
Makefile:68
- This jq-based schema rewrite rule no longer pulls/builds
jqas a Makefile prerequisite, so it will fail on environments wherejqisn't installed. Consider adding a preflight check so users get a clear error message (and an obvious remediation) instead of a generic "command not found".
.make/renovate-schema.json: .make/renovate-schema.orig.json hack/renovate/*.jq
cat $< | $(JQ) -f hack/renovate/delete-refs.jq > $@
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot remove all renovate related code from the application. Leave the repos own renovate configuration untouched. |
Co-authored-by: UnstoppableMango <20211602+UnstoppableMango@users.noreply.github.com>
Done. Removed |
Co-authored-by: UnstoppableMango <20211602+UnstoppableMango@users.noreply.github.com>
No description provided.