refactor(tools/openapi-gen)!: Wrap server in platform resp envelope#345
Draft
nderjung wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Wraps generated Gin server responses in the platform response envelope.
Changes:
- Updates service interfaces to return generic platform responses.
- Generates standardized error envelopes.
- Records request processing time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+292
to
+295
| Status: platform.ResponseStatusError, | ||
| Message: err.Error(), | ||
| Errors: []platform.ResponseError{{"{{"}}Status: http.StatusBadRequest{{"}}"}}, | ||
| OpTimeUs: uint64(time.Since(now).Microseconds()), |
nderjung
force-pushed
the
nderjung/refactor/tools/openapi-gen/templates/go-server/wrap-response
branch
from
6642b99 to
6e6f532
Compare
Contributor
|
should I approve/merge? |
Member
Author
Not just yet. Still doing a few little tests and need to open up some adjacent PRs since it's a breaking change still. Also roboto has some points. |
Match the go-client template by wrapping the go-server interface in the platform response envelope. Signed-off-by: Alexander Jung <alex@unikraft.com>
nderjung
force-pushed
the
nderjung/refactor/tools/openapi-gen/templates/go-server/wrap-response
branch
from
6e6f532 to
544ed69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the go-client template by wrapping the go-server interface
in the platform response envelope.
Signed-off-by: Alexander Jung alex@unikraft.com