Skip to content

feat(webapp): make native build server the default in build settings#3980

Open
myftija wants to merge 2 commits into
mainfrom
native-build-server-opt-out
Open

feat(webapp): make native build server the default in build settings#3980
myftija wants to merge 2 commits into
mainfrom
native-build-server-opt-out

Conversation

@myftija

@myftija myftija commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Switches the native build server from opt-in to opt-out in project build settings.

  • It's now enabled by default, stored as a new `disableNativeBuildServer` opt-out key so previously-saved `useNativeBuildServer: false` values aren't treated as deliberate opt-outs.
  • The "Use native build server" checkbox is checked by default; unchecking it persists the opt-out.
  • Brief wording: clarifies build settings apply to GitHub-triggered and native build server deployments, and the native build server hint no longer says "in the future".

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e48ef24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3277333a-a6d6-4f6d-a7cc-281c22ae7b9e

📥 Commits

Reviewing files that changed from the base of the PR and between 03e466e and e48ef24.

📒 Files selected for processing (1)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.settings.integrations/route.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.settings.integrations/route.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: code-quality / code-quality
  • GitHub Check: audit
  • GitHub Check: audit
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

The native build server setting changes from an opt-in useNativeBuildServer flag to an opt-out disableNativeBuildServer flag. The schema replaces the old field, while the route action persists the new flag only when the checkbox is unchecked. The form derives enabled state from the inverse flag, updates change detection and checkbox initialization, and revises related hints. Documentation describes the default behavior and deployment scope.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the change, but it misses required template sections like Closes #, Testing, Changelog, and Screenshots. Add the repository template sections: Closes #issue, checklist items, Testing steps, Changelog, and Screenshots or mark them N/A.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: native build server becomes the default in build settings.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch native-build-server-opt-out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@myftija myftija force-pushed the native-build-server-opt-out branch from 964d07e to 49dd55e Compare June 17, 2026 18:04

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 No server-side consumers of the native build server flag found

Searched the entire codebase for consumers of useNativeBuildServer or disableNativeBuildServer outside the settings UI route. Found zero usages in deployment services, GitHub-triggered deploy flows, or any backend build logic. The flag appears to be stored in the database but only read back by the settings UI presenter (apps/webapp/app/services/projectSettingsPresenter.server.ts:31). The CLI's nativeBuildServer option in packages/cli-v3/src/commands/deploy.ts:83 is a separate CLI flag (z.boolean().default(false)) that doesn't read from the server's buildSettings. This means the schema rename has no backend behavioral impact — it's purely a UI/storage concern. However, this raises the question: is the disableNativeBuildServer flag actually consumed by the GitHub-triggered deployment flow to decide whether to use the native build server? If not, this setting may be a no-op for that deployment path.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +7 to +9
// Opt-out flag: the native build server is used by default. Only set when a
// project explicitly disables it. Absence means native build server enabled.
disableNativeBuildServer: z.boolean().optional(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Implicit data migration via Zod key stripping — old useNativeBuildServer values silently dropped

Existing database records may contain { useNativeBuildServer: true } or { useNativeBuildServer: false } in the buildSettings JSON column. After the schema rename to disableNativeBuildServer at apps/webapp/app/v3/buildSettings.ts:9, Zod's default .object() behavior strips unrecognized keys during safeParse at apps/webapp/app/services/projectSettingsPresenter.server.ts:31. This means:

  • Projects with useNativeBuildServer: true → parsed as {}disableNativeBuildServer absent → treated as enabled ✓
  • Projects with useNativeBuildServer: false → parsed as {}disableNativeBuildServer absent → treated as enabled (was previously disabled)
  • Projects with no buildSettings at all → treated as enabled (was previously disabled)

This is the intended behavior per the PR description ("make native build server the default"), but it's worth noting that there is no explicit data migration — the behavior change happens implicitly through the schema rename. Projects that previously had native build server explicitly disabled will have it silently re-enabled. This is presumably acceptable since the PR is intentionally flipping the default, but reviewers should confirm this is the desired rollout strategy.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@trigger-dot-bot

trigger-dot-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

Preview Deployment

Status Preview Commit Updated
🟢 Ready native-build-server-opt-out.triggerlabs.dev e48ef24 Jul 10, 14:44 UTC

Switch the native build server from opt-in to opt-out. It's now enabled
by default and stored as a new `disableNativeBuildServer` opt-out key, so
previously-saved `useNativeBuildServer: false` values aren't mistaken for
deliberate opt-outs. Clarify in the UI that build settings apply to
GitHub-triggered and native build server deployments.
@myftija myftija force-pushed the native-build-server-opt-out branch from 49dd55e to 03e466e Compare July 10, 2026 09:12
@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@03e466e

trigger.dev

npm i https://pkg.pr.new/trigger.dev@03e466e

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@03e466e

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@03e466e

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@03e466e

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@03e466e

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@03e466e

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@03e466e

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@03e466e

commit: 03e466e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant