Add live filesystem asset mode - #3
Merged
Merged
Conversation
tomcatzh
force-pushed
the
codex/live-assets
branch
from
August 17, 2026 15:24
69f406b to
af36f48
Compare
tomcatzh
marked this pull request as ready for review
August 18, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live-assetsCargo feature without changing the existingEmbeddedSpaAPIrust-embedmetadata on every request in that modeWhy
Filesystem-backed
rust-embeddebug builds already read bytes from disk, butEmbeddedSpacached ETags and file membership during construction. Editing or adding frontend output after startup could therefore return a stale validator or an internal error. The new feature keeps one long-lived SPA service while making its development view of disk coherent.Developer impact
Applications can forward a local feature to
embedded-spa/live-assetsand run a normal debug build withoutrust-embed/debug-embed. The Axum fallback and handler code stay identical. Release builds continue to embed assets and should omit the development feature.Validation
make checkEMBEDDED_SPA_TEST_ORIGIN_PORT=28090 EMBEDDED_SPA_TEST_NGINX_PORT=28091 make test-nginxcargo package --allow-dirtycargo +1.88.0 test --all-targetscargo +1.88.0 test --all-targets --all-featurescargo test --release --all-targets --all-featuresThe Nginx matrix covered identity, gzip, and Brotli across eight MIME types, plus MISS, HIT, REVALIDATED, and conditional 304 behavior.