fix(slurm): use external controller in login pod - #39
Merged
jhu-svg merged 15 commits intoAug 3, 2026
Merged
Conversation
Render the configured external controller endpoint and mirrored Slurm auth Secret so hybrid managed-Slurm login pods can start without an in-cluster controller Service.
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
Publish the external-controller login fix as a distinct chart artifact so chart-host does not replace the immutable 1.0.0 package.
jhu-svg
force-pushed
the
TCL-6697/fix-managed-slurm-external-login
branch
from
July 20, 2026 01:25
6b0c324 to
ac9fe6f
Compare
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
Project the configured auth key to slurm.key and keep same-number TCP and UDP ports distinct during container merges.
Run the chart and operator tests before builds and refuse to overwrite stable operator image tags.
Use Go 1.25.3 in CI so cached standard-library objects match the compiler selected by go.mod.
Record that NodeSet ExtraConf is an intentional argv-level Slurm escape hatch and is never shell-evaluated.
Use commit-scoped concurrency for release pushes so a newer push cannot replace an older pending stable-image publication.
Lock in Kubernetes' empty-protocol-as-TCP behavior while preserving distinct UDP ports.
eb3095
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller.externalConfiginstead of a Service that Slinky intentionally omitssackdcan start1.0.3, Slurm operator chart1.0.1, and operator/webhook images1.0.13Dependencies
1.0.3and operator chart1.0.1; that PR must retain every production-referenced artifact and resolve its chart-host capacity decision before merge1.0.13Test plan
make helm-validatemake testslurmKeyRef.nameis missing1.0.3and operator chart1.0.1Publication note
slurm-operator:1.0.13andslurm-operator-webhook:1.0.13do not exist yet; merging toslurm-1.0-together-changestriggers their immutable publication. Verify both digests before deploying the dependent TCCO change.Linear: TCL-6697