[TCL-6909] feat(slurm): support initScriptController (/root/init.sh on slurmctld) - #36
Closed
sagrawal-byte wants to merge 1 commit into
Closed
Conversation
login (initScriptLogin) and compute (initScriptNodes) already mount a /root/init.sh init script via ConfigMap; the controller had no equivalent. Add initScriptController: a ConfigMap mounted at /root/init.sh on the slurmctld container, run at startup by the controller entrypoint (slurmcontainers controller.sh). Used to fetch role binaries (e.g. TorchPass) from the substrate metadata service. Gated/null by default -- no change to existing renders. Verified with helm lint + helm template. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sagrawal-byte
changed the title
This was referenced Jul 2, 2026
Author
|
Superseded — combined with #35 into a single PR from the merged branch (sagrawal/torchpass-chart-pkg). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
initScriptController— a/root/init.shinit-script hook for the controller (slurmctld), mirroring the existinginitScriptLogin(login) andinitScriptNodes(compute). When set, the chart renders a ConfigMap and mounts it at/root/init.shon the slurmctld container; the controller entrypoint runs it at startup.Pieces (all mirror the login/nodes equivalents):
controller-cr.yaml: injectinit-scriptvolume +/root/init.shsubPath mount onto slurmctld (gated oninitScriptController).init-script-configmap.yaml: new controller ConfigMap.slurm.initScriptControllerNamehelper.values.yaml:initScriptController: null.Companion: slurmcontainers
controller.shnow runs/root/init.sh(it already did transitively on worker via setup_env.sh, and directly on login).Why
Lets an operator-supplied init script run on all three roles. Primary use: fetch role binaries (TorchPass clockworks/payload) from the substrate metadata service at startup — avoiding private image pulls / payload initContainers.
Test plan
helm lint→ 0 failures.helm templatewithinitScriptControllerset: renders the ConfigMap + the slurmctld/root/init.shmount + theinit-scriptvolume (defaultMode 0755). Default (null) renders unchanged.🤖 Generated with Claude Code