device issues dashboard - #241
Draft
ewollesen wants to merge 31 commits into
Draft
Conversation
This better aligns with Todd's design intent, in that the service layer makes these decisions, as they're primarily business logic, and business logic belongs in the service layer.
Modifying this commit message to try to re-trigger a failed GitHub action. BACK-4414
Those states are migrated to a combination of data source an provider connection request. BACK-4414
re-work tests to match new data model, use gomega matchers
Shared to make things easier for the frontend to determine, and to keep it in sync with the backend. BACK-4382
The presence of a timestamp on the device issue document indicates that the issue should be hidden. BACK-4316
Contributor
Author
|
/deploy qa4 |
Collaborator
|
ewollesen updated values.yaml file in qa4 |
Collaborator
|
ewollesen updated flux policies file in qa4 |
Collaborator
|
ewollesen deployed clinic eric-di-endpoint branch to qa4 namespace |
This comment was marked as low quality.
This comment was marked as low quality.
Contributor
Author
|
/deploy qa4 |
Collaborator
|
ewollesen updated values.yaml file in qa4 |
Collaborator
|
ewollesen updated flux policies file in qa4 |
Collaborator
|
ewollesen deployed clinic eric-di-endpoint branch to qa4 namespace |
ewollesen
force-pushed
the
eric-di-endpoint
branch
3 times, most recently
from
June 30, 2026 08:16
9d19044 to
40f694b
Compare
After discussions with Henry, we'll need to have an "or" based query ability for device issues. In addition, it will be useful to be able to search for patients without any device issues, making this query a lot more like that used for filtering on clinic sites. BACK-4382
ewollesen
force-pushed
the
eric-di-endpoint
branch
from
June 30, 2026 10:33
40f694b to
4c58143
Compare
This fixes a bug where the transaction's context wasn't being used, negating the whole purpose of the transaction. BACK-4382
Before this change, a device issue that was previously hidden, would have had that state wiped out, due to the formulation of the mongodb query. BACK-4382
This way when a new provider is added, it has a better chance of being picked up automatically, since in theory there are fewer places that will need to be modified to pick up the new provider. BACK-4382
I had cut and paste the 5x StaleData lines instead of one line for each device issue type. BACK-4382
There's a chance this endpoint could become a performance issue. So we'll log its runtime, giving us at least a hint if it becomes an issue. BACK-4382
The bug fix is a guard to prevent a (highly unlikely) null dereference. BACK-4382
ewollesen
force-pushed
the
eric-di-endpoint
branch
from
July 13, 2026 08:25
96a5786 to
8d04d69
Compare
By default nothing changes, all tests are run, but if GINKGO_PACKAGES is specified, a subset of tests can be specified.
When a data source has moved from erroring or disconnected to the connected state, then the matching device issues should be removed. BACK-4382
Previously all device issues were cleared even if the device was connected both before and after, which could inadvertently clear out other device issues.
ewollesen
force-pushed
the
eric-migrate-pending-data-sources
branch
from
July 21, 2026 08:08
8fe3b7f to
26eef10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.