Skip to content

[BACK-2744] Add AnyHigh and AnyLow to Summaries - #127

Merged
Roukoswarf merged 9 commits into
masterfrom
anyhigh-anylow
Jan 5, 2024
Merged

[BACK-2744] Add AnyHigh and AnyLow to Summaries#127
Roukoswarf merged 9 commits into
masterfrom
anyhigh-anylow

Conversation

@Roukoswarf

Copy link
Copy Markdown
Contributor

No description provided.

ewollesen
ewollesen previously approved these changes Nov 8, 2023

@ewollesen ewollesen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just questions, assuming those questions don't turn up issues, then I think this is GTG.

Comment thread api/mappers.go
Comment thread api/mappers.go
Comment thread client/types.go
Comment thread client/types.go
Comment thread patients/tide.go Outdated
Comment thread client/client.go
Comment thread client/types.go
ewollesen
ewollesen previously approved these changes Nov 10, 2023

@ewollesen ewollesen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm sure you're aware, but just in case, make sure to have QA do a full regression, in case something got missed with all the pointer changes. :)

@Roukoswarf
Roukoswarf merged commit 0e82515 into master Jan 5, 2024
@Roukoswarf
Roukoswarf deleted the anyhigh-anylow branch January 5, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants