DST transitions fix - first draft - #8
Open
eduardtnica wants to merge 1 commit into
Open
Conversation
fische
reviewed
Jul 27, 2026
| // An hour may have 60 minutes, 30 minutes or 90 minutes; | ||
| // partial hours may "repeat"! | ||
|
|
||
| // --- Spring-Forward Mitigation (Transition Day Interceptor) --- |
There was a problem hiding this comment.
Would be good to add as comment here, an explanation of the algorithm below.
Comment on lines
+313
to
+315
| for _, h := range expr.hourList { | ||
| for _, m := range expr.minuteList { | ||
| for _, s := range expr.secondList { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix implements native, timezone-offset aware "exactly-once" execution guarantees for scheduled jobs crossing Daylight Saving Time (DST) transitions. This modifies our internal cronexpr library fork to prevent duplicate executions during Fall-Back transitions (clocks repeating an hour) and missed executions during Spring-Forward transitions (clocks skipping an hour) for all infrequent (less-than-hourly) schedules.