fix: a finer partition generates the larger algebra (IsPartition.mono) - #641
Merged
Merged
Conversation
IsPartition.mono had the inequality the wrong way round: parts_I finer than parts_J means every I-atom sits inside a J-atom, so the algebra generated by parts_I contains the one generated by parts_J. As stated it was false — the discrete partition is finer than the trivial one, giving ⊤ ≤ ⊥ — and it also contradicted DyadicCube'.boolean_algebra_mono just below, where the finer scale n ≥ m sits on the larger side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsPartition.monohas the inequality backwards.finer_thansays each I-atom sits inside a J-atom, so the I-algebra is the bigger one. As written it's false: the discrete partition is finer than the trivial one, so it would give ⊤ ≤ ⊥. It also disagreed withDyadicCube'.boolean_algebra_monoright below, which puts the finer scale on the larger side.Generated by Claude Code