Fix first-run plstore path validation - #23
Merged
Conversation
telotortium
marked this pull request as ready for review
July 25, 2026 01:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file-equal-pRoot cause
file-equal-preturns nil when its target does not exist, even when both arguments name the same path. On the first OAuth save, the safety guard therefore misclassified the new plstore buffer as an unrelated file. Pre-creating an empty file made the workaround succeed only becausefile-equal-pcould then compare filesystem identity.Impact
First-time authentication can create the plstore normally without requiring users to pre-create an empty file, while the protection against writing secrets into Org or other unrelated buffers remains active.
This addresses the first-run failure and workaround reported in #6.
Validation
make all