(data) ja SV4a Shiny Treasure ex - cardmarket + tcgplayer product ids - #1864
(data) ja SV4a Shiny Treasure ex - cardmarket + tcgplayer product ids#1864KlausDerKleber wants to merge 1 commit into
Conversation
Links the cards of the existing Japanese set **SV4a シャイニートレジャーex (Shiny Treasure ex)** to their Cardmarket **and TCGplayer** products, so the API can serve their prices. - **319** cards carried no product id at all and get both - **1** carried a card-level `thirdParty.cardmarket`, which is moved onto the card's `variants` entry and joined by its tcgplayer id - **1** carried the cardmarket id of a different print and are corrected Afterwards every card of the set carries its id on a `variants` entry and none on the card itself, which is where tcgdex is heading. Nothing else changes: the `zh-tw`/`th`/`id` texts and the Japanese card data are not rewritten. 1 cards carried the product of **another print** of the same card, so the API served that print's price for them: | card | was | is | the old id belongs to | |---|---|---|---| | 303 | 734291 | 747657 | not a product of this set's cardmarket expansion | The ids are assigned **by collection number**, not by name: within a Cardmarket expansion the products sorted by `idProduct` follow the collection order, and the assignment is verified against the sample rows pokepricelab renders. That matters because Cardmarket names every print of a card identically inside an expansion, so a name lookup cannot tell a base print from its AR/full-art reprint — which is where the corrected ids above come from. This set carried no id yet, so there is nothing in the repository to cross-check the assignment against — it rests on the verified ordering alone. - **Cardmarket** public product catalog (`downloads.s3.cardmarket.com`): the product ids (746203–747714), assigned by collection number - **pokepricelab.com**: the sample rows that verify that assignment - **TCGplayer** via [tcgcsv.com](https://tcgcsv.com) (category 85, "Pokemon Japan"): product IDs as `thirdParty.tcgplayer` (567347–577567), keyed by the collection number each product carries in `extendedData` - **limitlesstcg.com**: the set's card list — used here for nothing but the rarity per number, which decides whether a variant is `holo` or `normal` - `tsc --noEmit` reports the same 301 pre-existing errors as upstream/master — this change adds none. They are `rarity` being required by `interfaces.d.ts` while these older hand-written files omit it, which is out of scope here.
🃏 320 Cards ChangedDetails: 320 modified ナゾノクサ (SV4a-001) (found using ja)
File: data-asia/SV/SV4a/001.ts クサイハナ (SV4a-002) (found using ja)
File: data-asia/SV/SV4a/002.ts ラフレシア (SV4a-003) (found using ja)
File: data-asia/SV/SV4a/003.ts ストライク (SV4a-004) (found using ja)
File: data-asia/SV/SV4a/004.ts ハネッコ (SV4a-005) (found using ja)
File: data-asia/SV/SV4a/005.ts ポポッコ (SV4a-006) (found using ja)
File: data-asia/SV/SV4a/006.ts ワタッコ (SV4a-007) (found using ja)
File: data-asia/SV/SV4a/007.ts クヌギダマ (SV4a-008) (found using ja)
File: data-asia/SV/SV4a/008.ts フォレトスex (SV4a-009) (found using ja)
File: data-asia/SV/SV4a/009.ts ユキカブリ (SV4a-010) (found using ja)
File: data-asia/SV/SV4a/010.ts ユキノオー (SV4a-011) (found using ja)
File: data-asia/SV/SV4a/011.ts ニャオハ (SV4a-012) (found using ja)
File: data-asia/SV/SV4a/012.ts ニャローテ (SV4a-013) (found using ja)
File: data-asia/SV/SV4a/013.ts マスカーニャex (SV4a-014) (found using ja)
File: data-asia/SV/SV4a/014.ts ミニーブ (SV4a-015) (found using ja)
File: data-asia/SV/SV4a/015.ts オリーニョ (SV4a-016) (found using ja)
File: data-asia/SV/SV4a/016.ts オリーヴァ (SV4a-017) (found using ja)
File: data-asia/SV/SV4a/017.ts ノノクラゲ (SV4a-018) (found using ja)
File: data-asia/SV/SV4a/018.ts リククラゲex (SV4a-019) (found using ja)
File: data-asia/SV/SV4a/019.ts カプサイジ (SV4a-020) (found using ja)
File: data-asia/SV/SV4a/020.ts スコヴィラン (SV4a-021) (found using ja)
File: data-asia/SV/SV4a/021.ts シガロコ (SV4a-022) (found using ja)
File: data-asia/SV/SV4a/022.ts クエスパトラex (SV4a-023) (found using ja)
File: data-asia/SV/SV4a/023.ts チオンジェンex (SV4a-024) (found using ja)
File: data-asia/SV/SV4a/024.ts ヒトカゲ (SV4a-025) (found using ja)
File: data-asia/SV/SV4a/025.ts リザード (SV4a-026) (found using ja)
File: data-asia/SV/SV4a/026.ts パルデア ケンタロス (SV4a-027) (found using ja)
File: data-asia/SV/SV4a/027.ts エンテイ (SV4a-028) (found using ja)
File: data-asia/SV/SV4a/028.ts オドリドリ (SV4a-029) (found using ja)
File: data-asia/SV/SV4a/029.ts ホゲータ (SV4a-030) (found using ja)
File: data-asia/SV/SV4a/030.ts アチゲータ (SV4a-031) (found using ja)
File: data-asia/SV/SV4a/031.ts ラウドボーンex (SV4a-032) (found using ja)
File: data-asia/SV/SV4a/032.ts カルボウ (SV4a-033) (found using ja)
File: data-asia/SV/SV4a/033.ts グレンアルマ (SV4a-034) (found using ja)
File: data-asia/SV/SV4a/034.ts イーユイex (SV4a-035) (found using ja)
File: data-asia/SV/SV4a/035.ts ヤドン (SV4a-036) (found using ja)
File: data-asia/SV/SV4a/036.ts ヤドラン (SV4a-037) (found using ja)
File: data-asia/SV/SV4a/037.ts ヒトデマン (SV4a-038) (found using ja)
File: data-asia/SV/SV4a/038.ts スターミー (SV4a-039) (found using ja)
File: data-asia/SV/SV4a/039.ts パルデア ケンタロス (SV4a-040) (found using ja)
File: data-asia/SV/SV4a/040.ts クワッス (SV4a-041) (found using ja)
File: data-asia/SV/SV4a/041.ts ウェルカモ (SV4a-042) (found using ja)
File: data-asia/SV/SV4a/042.ts ウェーニバルex (SV4a-043) (found using ja)
File: data-asia/SV/SV4a/043.ts ウミディグダ (SV4a-044) (found using ja)
File: data-asia/SV/SV4a/044.ts ウミトリオ (SV4a-045) (found using ja)
File: data-asia/SV/SV4a/045.ts ナミイルカ (SV4a-046) (found using ja)
File: data-asia/SV/SV4a/046.ts イルカマン (SV4a-047) (found using ja)
File: data-asia/SV/SV4a/047.ts ミガルーサ (SV4a-048) (found using ja)
File: data-asia/SV/SV4a/048.ts ヘイラッシャ (SV4a-049) (found using ja)
File: data-asia/SV/SV4a/049.ts シャリタツ (SV4a-050) (found using ja)
File: data-asia/SV/SV4a/050.ts セビエ (SV4a-051) (found using ja)
File: data-asia/SV/SV4a/051.ts セゴール (SV4a-052) (found using ja)
File: data-asia/SV/SV4a/052.ts
|
2 participants
What
Links the cards of the existing Japanese set SV4a シャイニートレジャーex (Shiny Treasure ex) to their Cardmarket and TCGplayer products, so the API can serve their prices.
thirdParty.cardmarket, which is moved onto the card'svariantsentry and joined by its tcgplayer idAfterwards every card of the set carries its id on a
variantsentry and none on the card itself, which is where tcgdex is heading. Nothing else changes: thezh-tw/th/idtexts and the Japanese card data are not rewritten.1 cards carried the product of another print of the same card, so the API served that print's price for them:
The ids are assigned by collection number, not by name: within a Cardmarket expansion the products sorted by
idProductfollow the collection order, and the assignment is verified against the sample rows pokepricelab renders. That matters because Cardmarket names every print of a card identically inside an expansion, so a name lookup cannot tell a base print from its AR/full-art reprint — which is where the corrected ids above come from. This set carried no id yet, so there is nothing in the repository to cross-check the assignment against — it rests on the verified ordering alone.Data sources
downloads.s3.cardmarket.com): the product ids (746203–747714), assigned by collection numberthirdParty.tcgplayer(567347–577567), keyed by the collection number each product carries inextendedDataholoornormalNotes
tsc --noEmitreports the same 301 pre-existing errors as upstream/master — this change adds none. They areraritybeing required byinterfaces.d.tswhile these older hand-written files omit it, which is out of scope here.