(data) ja S12 Paradigm Trigger - cardmarket + tcgplayer product ids - #1855
(data) ja S12 Paradigm Trigger - cardmarket + tcgplayer product ids#1855KlausDerKleber wants to merge 1 commit into
Conversation
🃏 125 Cards ChangedDetails: 125 modified ナゾノクサ (S12-001) (found using ja)
File: data-asia/S/S12/001.ts クサイハナ (S12-002) (found using ja)
File: data-asia/S/S12/002.ts キレイハナ (S12-003) (found using ja)
File: data-asia/S/S12/003.ts モンジャラ (S12-004) (found using ja)
File: data-asia/S/S12/004.ts モジャンボ (S12-005) (found using ja)
File: data-asia/S/S12/005.ts イトマル (S12-006) (found using ja)
File: data-asia/S/S12/006.ts アリアドス (S12-007) (found using ja)
File: data-asia/S/S12/007.ts ビリジオン (S12-008) (found using ja)
File: data-asia/S/S12/008.ts ブリガロンV (S12-009) (found using ja)
File: data-asia/S/S12/009.ts ポニータ (S12-010) (found using ja)
File: data-asia/S/S12/010.ts ギャロップ (S12-011) (found using ja)
File: data-asia/S/S12/011.ts ビクティニ (S12-012) (found using ja)
File: data-asia/S/S12/012.ts メラルバ (S12-013) (found using ja)
File: data-asia/S/S12/013.ts ウルガモス (S12-014) (found using ja)
File: data-asia/S/S12/014.ts ニャビー (S12-015) (found using ja)
File: data-asia/S/S12/015.ts ニャヒート (S12-016) (found using ja)
File: data-asia/S/S12/016.ts ガオガエン (S12-017) (found using ja)
File: data-asia/S/S12/017.ts オムスターV (S12-018) (found using ja)
File: data-asia/S/S12/018.ts ユキワラシ (S12-019) (found using ja)
File: data-asia/S/S12/019.ts オニゴーリ (S12-020) (found using ja)
File: data-asia/S/S12/020.ts ユキメノコ (S12-021) (found using ja)
File: data-asia/S/S12/021.ts ジーランス (S12-022) (found using ja)
File: data-asia/S/S12/022.ts ケルディオ (S12-023) (found using ja)
File: data-asia/S/S12/023.ts ピカチュウ (S12-024) (found using ja)
File: data-asia/S/S12/024.ts ライチュウ (S12-025) (found using ja)
File: data-asia/S/S12/025.ts コリンク (S12-026) (found using ja)
File: data-asia/S/S12/026.ts ルクシオ (S12-027) (found using ja)
File: data-asia/S/S12/027.ts レントラー (S12-028) (found using ja)
File: data-asia/S/S12/028.ts マッギョ (S12-029) (found using ja)
File: data-asia/S/S12/029.ts エリキテル (S12-030) (found using ja)
File: data-asia/S/S12/030.ts エレザード (S12-031) (found using ja)
File: data-asia/S/S12/031.ts ゼラオラ (S12-032) (found using ja)
File: data-asia/S/S12/032.ts レジエレキV (S12-033) (found using ja)
File: data-asia/S/S12/033.ts レジエレキVMAX (S12-034) (found using ja)
File: data-asia/S/S12/034.ts アンノーンV (S12-035) (found using ja)
File: data-asia/S/S12/035.ts アンノーンVSTAR (S12-036) (found using ja)
File: data-asia/S/S12/036.ts アサナン (S12-037) (found using ja)
File: data-asia/S/S12/037.ts チャーレム (S12-038) (found using ja)
File: data-asia/S/S12/038.ts シンボラー (S12-039) (found using ja)
File: data-asia/S/S12/039.ts ユニラン (S12-040) (found using ja)
File: data-asia/S/S12/040.ts ダブラン (S12-041) (found using ja)
File: data-asia/S/S12/041.ts ランクルス (S12-042) (found using ja)
File: data-asia/S/S12/042.ts リグレー (S12-043) (found using ja)
File: data-asia/S/S12/043.ts オーベム (S12-044) (found using ja)
File: data-asia/S/S12/044.ts デデンネ (S12-045) (found using ja)
File: data-asia/S/S12/045.ts ヒスイ ウインディV (S12-046) (found using ja)
File: data-asia/S/S12/046.ts ヤジロン (S12-047) (found using ja)
File: data-asia/S/S12/047.ts ネンドール (S12-048) (found using ja)
File: data-asia/S/S12/048.ts アノプス (S12-049) (found using ja)
File: data-asia/S/S12/049.ts アーマルド (S12-050) (found using ja)
File: data-asia/S/S12/050.ts テラキオン (S12-051) (found using ja)
File: data-asia/S/S12/051.ts ヤンチャム (S12-052) (found using ja)
File: data-asia/S/S12/052.ts イワンコ (S12-053) (found using ja)
File: data-asia/S/S12/053.ts
|
Links the cards of the existing Japanese set **S12 パラダイムトリガー (Paradigm Trigger)** to their Cardmarket **and TCGplayer** products, so the API can serve their prices. - **50** cards carried no product id at all and get both - **75** carried a card-level `thirdParty.cardmarket`, which is moved onto the card's `variants` entry and joined by its tcgplayer id - **3** carried the cardmarket id of a different print and are corrected Afterwards every card of the set carries its id on a `variants` entry and none on the card itself, which is where tcgdex is heading. Nothing else changes: the `zh-tw`/`th` texts and the Japanese card data are not rewritten. 3 cards carried the product of **another print** of the same card, so the API served that print's price for them: | card | was | is | the old id belongs to | |---|---|---|---| | 116 | 680175 | 680850 | points at card 036 of this set | | 118 | 680219 | 680852 | points at card 080 of this set | | 123 | 680219 | 680857 | points at card 080 of this set | The ids are assigned **by collection number**, not by name: within a Cardmarket expansion the products sorted by `idProduct` follow the collection order, and the assignment is verified against the sample rows pokepricelab renders. That matters because Cardmarket names every print of a card identically inside an expansion, so a name lookup cannot tell a base print from its AR/full-art reprint — which is where the corrected ids above come from. That the 72 ids this set already carried correctly agree with the same assignment is an independent cross-check. - **Cardmarket** public product catalog (`downloads.s3.cardmarket.com`): the product ids (680140–680859), assigned by collection number - **pokepricelab.com**: the sample rows that verify that assignment - **TCGplayer** via [tcgcsv.com](https://tcgcsv.com) (category 85, "Pokemon Japan"): product IDs as `thirdParty.tcgplayer` (570059–570183), keyed by the collection number each product carries in `extendedData` - **limitlesstcg.com**: the set's card list — used here for nothing but the rarity per number, which decides whether a variant is `holo` or `normal` - `tsc --noEmit` reports the same 31 pre-existing errors as upstream/master — this change adds none. They are `rarity` being required by `interfaces.d.ts` while these older hand-written files omit it, which is out of scope here.
3dee21d to
04c26ec
Compare
2 participants
What
Links the cards of the existing Japanese set S12 パラダイムトリガー (Paradigm Trigger) to their Cardmarket and TCGplayer products, so the API can serve their prices.
thirdParty.cardmarket, which is moved onto the card'svariantsentry and joined by its tcgplayer idAfterwards every card of the set carries its id on a
variantsentry and none on the card itself, which is where tcgdex is heading. Nothing else changes: thezh-tw/thtexts and the Japanese card data are not rewritten.3 cards carried the product of another print of the same card, so the API served that print's price for them:
The ids are assigned by collection number, not by name: within a Cardmarket expansion the products sorted by
idProductfollow the collection order, and the assignment is verified against the sample rows pokepricelab renders. That matters because Cardmarket names every print of a card identically inside an expansion, so a name lookup cannot tell a base print from its AR/full-art reprint — which is where the corrected ids above come from. That the 72 ids this set already carried correctly agree with the same assignment is an independent cross-check.Data sources
downloads.s3.cardmarket.com): the product ids (680140–680859), assigned by collection numberthirdParty.tcgplayer(570059–570183), keyed by the collection number each product carries inextendedDataholoornormalNotes
tsc --noEmitreports the same 31 pre-existing errors as upstream/master — this change adds none. They areraritybeing required byinterfaces.d.tswhile these older hand-written files omit it, which is out of scope here.