Check-in some changes to run the kernels correctly by Jackcuii · Pull Request #323 · tancheng/VectorCGRA

Jackcuii · 2026-07-12T16:24:59Z

No description provided.

…rnels

- Add CgraRTL_relu4x4_test_from_yaml.py: ReLU kernel test on 4x4 Mesh CGRA using relu.yaml compiled kernel config (II=5, 32 iterations) - Fix script_generator.py: swap STORE src_operands to match MemUnitRTL hardware expectation (in0=address, in1=data vs YAML order [data, addr])

…amls

…flag Bug #1 - CrossbarRTL all-or-nothing: Stale prologued data blocked entire crossbar - Mask recv_valid_vector, exclude prologued from send/recv_required_vector - Gate changed: recv_valid_or_prologue_allowing_vector Bug #2 - PhiRTL shared first flag: Multiple PHI_START on same tile failed - Detect iteration wrap via ctrl_addr, clear s.first only at boundaries - Added prev_ctrl_addr tracking Tests: ReLU 379 cycles (pass), SpMV 759 cycles (pass)

…rnels

Jackcuii · 2026-07-16T01:29:15Z

Added cleanup commit ce34b9b:

removed all visualizer/ files
removed all tracked trace_output/ files
removed validation artifacts not directly referenced by tracked test/test_from_yaml code
retained only script_generator.py and the eight newly added YAML files used by tracked tests

Python syntax checks pass. Pytest collection from the repository root is blocked by the project package layout (attempted relative import beyond top-level package), unrelated to the removed validation files.

# Conflicts: # fu/single/CompRTL.py # fu/single/test/CompRTL_test.py

Jackcuii · 2026-07-16T01:47:02Z

Detailed RTL-level change summary

This comment covers every *RTL.py file currently changed by this PR relative to the latest master. It describes both what changed and why the change is needed.

1. `cgra/CgraRTL.py`

What changed

line_trace() now obtains the optional structured trace logger through get_trace_logger().
When logging is enabled, the complete CGRA state is recorded once when line_trace() is invoked.
The existing human-readable line trace is unchanged.

Purpose

The structured log provides cycle-by-cycle machine-readable state for debugging long-running compiled kernels. It makes it possible to correlate tile/FU activity, control state, routing behavior, and memory activity without parsing the existing free-form line trace. The logger remains optional, so normal simulations do not need to enable it.

2. `fu/single/GrantRTL.py`

What changed

Replaced the single global already_grt_once bit with one bit per control-memory slot (ctrl_addr).
Added cur_already_grt_once to select the state associated with the currently executing control slot.
Added support for OPT_GRT_ONCE_CONST, which takes its value from the constant queue instead of a regular FU input.
Both OPT_GRT_ONCE and OPT_GRT_ONCE_CONST set the per-slot state only after a successful output valid/ready handshake.
Reset and clear now reset every slot independently.

Purpose

A tile can contain more than one GRANT_ONCE operation at different control addresses. A single shared bit caused the first operation to suppress all later operations on that tile. Per-slot state makes each scheduled operation independent. OPT_GRT_ONCE_CONST is needed for compiled kernels in which a loop-invariant or entry-block value is supplied by the constant queue and must receive a true predicate exactly once.

3. `fu/single/MemUnitRTL.py`

What changed

For OPT_STR, both the write-address valid signal and write-data valid signal are now gated by the predicates of the address and data inputs.
The existing valid/ready data-consumption behavior is otherwise unchanged.

Purpose

During pipeline drain cycles, a token may still have val=1 while carrying predicate=0. Previously, OPT_STR treated such a token as a real memory write and could overwrite a correct result with invalid drain data. Requiring both input predicates prevents side effects from predicated-off stores while still consuming the pipeline token normally.

4. `fu/single/PhiRTL.py`

What changed

Added handling for OPT_CONST inside the Phi FU.
The operation forwards the constant payload, combines the constant predicate with reached_vector_factor, and implements the normal constant/output valid-ready handshake.
The existing per-control-slot PHI first-execution state from master is retained.

Purpose

The compiled schedule can map a plain constant-producing operation onto a tile configuration that uses the Phi-capable FU. Supporting OPT_CONST here avoids rejecting or stalling that schedule and preserves normal predicate/vector-factor behavior.

5. `fu/single/ShifterRTL.py`

What changed

Added OPT_LLS_CONST for logical left shift by a constant amount.
The data operand comes from the selected FU input and the shift amount comes from the constant queue.
Output predicate, valid, and ready signals account for both operands and reached_vector_factor.

Purpose

Compiled address and index calculations frequently contain shifts by a compile-time constant. Supporting a constant shift avoids consuming a second routed FU input and allows the YAML generator to represent these operations directly.

6. `mem/const/ConstQueueDynamicRTL.py`

What changed

Added a consume_pending state bit.
A constant read handshake is remembered when send_const.rdy occurs before ctrl_proceed.
The pending consumption retires and advances the read cursor on the next ctrl_proceed pulse.
Reset/clear resets both the read cursor and pending state.

Purpose

The previous implementation advanced the queue only when send_const.rdy and ctrl_proceed were asserted in the same cycle. At iteration boundaries, another tile submodule can delay ctrl_proceed, causing an already-consumed constant to remain at the head of the queue. Remembering the pending consumption prevents constant-order corruption and repeated constants.

7. `mem/ctrl/CtrlMemDynamicRTL.py`

What changed

Added CMD_CONFIG_GEP_STRIDE to the set of controller commands forwarded to the tile element.
Added the same command to the set that is acknowledged/consumed from the controller packet queue.

Purpose

Two-dimensional GEP operations require runtime configuration of their stride. Without forwarding and consuming this command, the configuration packet can stall in control memory and the FU never receives the required stride value.

8. `mem/register_cluster/RegisterClusterRTL.py`

What changed

Relaxed recv_data_from_routing_crossbar[i].rdy so routing tokens can be consumed when:
- the current operation is OPT_NAH,
- the FU does not select this lane,
- the register bank supplies the FU input for this lane, or
- the FU output path is ready.
The previous, more conservative master condition is retained next to the implementation as a comment for comparison.
Most of the apparent full-file diff is line-ending normalization; the ready condition above is the functional change.

Purpose

Routing-crossbar tokens should not remain blocked merely because the FU is not consuming that lane. In compiled schedules this produced cycle gaps and could backpressure the routing network even when the token was irrelevant to the current FU operation. The relaxed condition drains unused routing tokens while preserving normal FU consumption when the lane is selected.

9. `noc/CrossbarRTL.py`

What changed

Prologued inputs are treated as satisfied for the all-input-valid gate, allowing non-prologued traffic to proceed.
A prologued output no longer requires downstream ready because no token should be sent on that output during the prologue.
Physical input data is masked from recv_valid_vector while the corresponding route is in its prologue period.
recv_required_vector excludes prologued routes and uses set-only/OR-style accumulation so multicast outputs sharing one input cannot overwrite one another's requirement.
send_required_vector excludes prologued outputs.
Output val and input dequeue logic use recv_valid_or_during_prologue_allowing_vector, while the required vectors ensure that prologued channels are neither sent nor consumed.

Purpose

The earlier crossbar could see stale physical data on a prologued route, attempt to send it, and then block the entire all-or-nothing multicast transaction when the destination was full. It could also let a bypassed/prologued route suppress unrelated valid traffic. These changes make prologue bypass explicit on both the input and output sides, prevent accidental consumption, preserve multicast requirements, and eliminate the observed SpMV deadlock.

10. `tile/TileRTL.py`

What changed

Added CMD_CONFIG_GEP_STRIDE to the controller commands routed from the tile's controller interface into CtrlMemDynamicRTL.
Removed two trailing spaces; those are formatting-only changes.

Purpose

This is the tile-level half of GEP stride delivery. TileRTL must accept and route the command before CtrlMemDynamicRTL can forward it to the element. Without this condition, the stride configuration would never enter the tile control path.

Note about `CompRTL.py`

CompRTL.py and CompRTL_test.py were previously modified by this branch, but they are no longer part of the current PR diff. After master merged its constant-comparison predicate semantics, the conflict was resolved by taking the master versions. Constant comparisons therefore follow master and require the data predicate, constant predicate, and reached_vector_factor.

Jackcuii · 2026-07-16T13:33:39Z

Update: The translation works well. The signal_a[signal_b] can be translated.
YoSys do report some comb loop warnings, but they seem not to be a new-introduced problem.

Jackcuii · 2026-07-16T13:34:58Z

Update: The reason of CI test fail is the invalid var that Verilog not support

tancheng · 2026-07-16T19:41:09Z

Update: The reason of CI test fail is the invalid var that Verilog not support

what is the invalid var you are referring to?

tancheng · 2026-07-16T19:42:38Z

The trace-related changes in this file can be reverted.

tancheng · 2026-07-16T19:43:14Z

the changes in this file can be reverted.

hmm, if you think this can help debugging, maybe we can also leave it there? as long as it can be conditionally invoked.

tancheng · 2026-07-16T19:44:42Z

we can check this in if you want.

tancheng · 2026-07-18T03:56:58Z

Hi @Jackcuii, can you resolve the comments if you have bandwidth? I would like to merge some register bank related fixes after yours: #322

Jackcuii · 2026-07-18T15:35:15Z

Hi @Jackcuii, can you resolve the comments if you have bandwidth? I would like to merge some register bank related fixes after yours: #322

Hi Sir Tan, I was working on it～ However I caught a fever yesterday 🥵. Hopefully I will be better and back tomorrow.

Jackcuii · 2026-07-18T15:35:53Z

Update: The reason of CI test fail is the invalid var that Verilog not support

what is the invalid var you are referring to?

Oh sorry It is a typo, I mean char😂

tancheng · 2026-07-18T16:10:33Z

Hi @Jackcuii, can you resolve the comments if you have bandwidth? I would like to merge some register bank related fixes after yours: #322

Hi Sir Tan, I was working on it～ However I caught a fever yesterday 🥵. Hopefully I will be better and back tomorrow.

Ah, take care, get better soon!

tancheng · 2026-07-23T01:03:07Z

+        s.recv_data_from_routing_crossbar[i].rdy @= \
+            (s.inport_opt.operation == OPT_NAH) | \
+            (s.inport_opt.fu_in[i] == 0) | \
+            reg_towards_fu | \
+            s.send_data_to_fu[i].rdy


@yyan7223 does this make sense to you?

tancheng · 2026-07-23T01:04:37Z

@yyan7223 can you plz take a look at this change?

tancheng · 2026-07-24T03:55:32Z

Hi @Jackcuii, as long as you can resolve my comments, it should be okay to check in. Plz try to resolve them ASAP. Thanks!

Jackcuii · 2026-07-25T02:27:34Z

Hi @Jackcuii, as long as you can resolve my comments, it should be okay to check in. Plz try to resolve them ASAP. Thanks!

Okay~ I am checking in the logics the comments mentioned in the branch one by one to make sure all the yaml tests can still pass. It is somehow black-boxed😂

tancheng · 2026-07-27T00:37:21Z

Hi @Jackcuii, as long as you can resolve my comments, it should be okay to check in. Plz try to resolve them ASAP. Thanks!

Okay~ I am checking in the logics the comments mentioned in the branch one by one to make sure all the yaml tests can still pass. It is somehow black-boxed😂

I understand that. Can you then ask your agent to apply my suggestions to see whether it works?

Jackcuii · 2026-07-29T17:46:59Z

Sadly some comments will cause some tests to fail, I am working on it

Jackcuii · 2026-07-29T17:48:21Z

new TODO: merge #322 to this branch after folks' reviews

tancheng · 2026-07-29T18:45:53Z

new TODO: merge #322 to this branch after folks' reviews

I just merged it

tancheng · 2026-08-08T01:11:04Z

@Jackcuii I remember you mentioned that you would update the tests, and double-check the last one finished or not?

So then we can review again and merge this?

Jackcuii and others added 30 commits March 29, 2026 09:05

merge master

7b13b42

Merge remote-tracking branch 'origin/master' into fulfill-compiled-ke…

4997351

…rnels

add visualizer for debugging

2142819

add trace support

f0e5b7a

fix multiple bugs in script_generator

4e11bcb

add compiled kernel files

723899d

add compiled kernels

b2c388b

add grant_once_const

15407d6

fix opcode collision

b47f363

add relu kernel

da6255f

support SGE_CONST

4df8179

Update final version kernels

bf6a598

add axpy/histogram

97e0227

add DIV_CONST, support multi-cycle prologue, update visualizer, add y…

c8cd631

…amls

spmv and assist files

7f1af27

assist files

5117354

Merge remote-tracking branch 'origin/master' into fulfill-compiled-ke…

66f84f8

…rnels

add conv

4a87991

fix collision of opcode

6196bf5

add gemm and gemv (Note new genarator may not apply to gemv)

1e4bc24

add sad & fix bugs

53365b4

fix axpy

9390d1f

add timeline plot

64487a3

fix cycle gap

fe8b7f0

update histo input

4b78fc6

fix generator

dd7c62b

fix signed compare

86397d3

add drain cycles

b727f99

Jackcuii closed this Jul 15, 2026

Jackcuii mentioned this pull request Jul 15, 2026

Check-in existing features in kernel debugging #318

Open

Jackcuii reopened this Jul 16, 2026

Remove visualization artifacts and unused validation files

ce34b9b

Merge remote-tracking branch 'origin/master' into kernel-submit

f65deef

# Conflicts: # fu/single/CompRTL.py # fu/single/test/CompRTL_test.py

Fix non-ASCII RTL comments for Verilog translation

0287bdf

tancheng reviewed Jul 16, 2026

View reviewed changes

Jackcuii added 2 commits July 22, 2026 10:48

Move constant handling from PhiRTL to ConstRTL

ebde1ec

Normalize RegisterClusterRTL line endings

49b8331

tancheng reviewed Jul 23, 2026

View reviewed changes

tancheng reviewed Jul 24, 2026

View reviewed changes

Comment thread mem/register_cluster/RegisterClusterRTL.py Outdated

tancheng reviewed Jul 24, 2026

View reviewed changes

Comment thread noc/CrossbarRTL.py Outdated

Comment thread noc/CrossbarRTL.py Outdated

Comment thread noc/CrossbarRTL.py Outdated

Comment thread noc/CrossbarRTL.py Outdated

Comment thread mem/register_cluster/RegisterClusterRTL.py Outdated

Bohan Cui added 2 commits August 5, 2026 19:58

Fix shuffled FU input lane readiness

acf0ebe

Clarify prologue crossbar signal names

e6d089d

Conversation

Jackcuii commented Jul 12, 2026

Uh oh!

Jackcuii commented Jul 16, 2026

Uh oh!

Jackcuii commented Jul 16, 2026

Detailed RTL-level change summary

1. cgra/CgraRTL.py

2. fu/single/GrantRTL.py

3. fu/single/MemUnitRTL.py

4. fu/single/PhiRTL.py

5. fu/single/ShifterRTL.py

6. mem/const/ConstQueueDynamicRTL.py

7. mem/ctrl/CtrlMemDynamicRTL.py

8. mem/register_cluster/RegisterClusterRTL.py

9. noc/CrossbarRTL.py

10. tile/TileRTL.py

Note about CompRTL.py

Uh oh!

Jackcuii commented Jul 16, 2026

Uh oh!

Jackcuii commented Jul 16, 2026

Uh oh!

tancheng commented Jul 16, 2026

Uh oh!

tancheng Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

tancheng Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

tancheng Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tancheng commented Jul 18, 2026

Uh oh!

Jackcuii commented Jul 18, 2026

Uh oh!

Jackcuii commented Jul 18, 2026

Uh oh!

tancheng commented Jul 18, 2026

Uh oh!

tancheng Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

tancheng Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tancheng commented Jul 24, 2026

Uh oh!

Jackcuii commented Jul 25, 2026

Uh oh!

tancheng commented Jul 27, 2026

Uh oh!

Jackcuii commented Jul 29, 2026

Uh oh!

Jackcuii commented Jul 29, 2026

Uh oh!

tancheng commented Jul 29, 2026

Uh oh!

tancheng commented Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

1. `cgra/CgraRTL.py`

2. `fu/single/GrantRTL.py`

3. `fu/single/MemUnitRTL.py`

4. `fu/single/PhiRTL.py`

5. `fu/single/ShifterRTL.py`

6. `mem/const/ConstQueueDynamicRTL.py`

7. `mem/ctrl/CtrlMemDynamicRTL.py`

8. `mem/register_cluster/RegisterClusterRTL.py`

9. `noc/CrossbarRTL.py`

10. `tile/TileRTL.py`

Note about `CompRTL.py`