Feat/local memory provider - #42
Conversation
Add deploy registry, status CLI, tests, and documentation updates.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf975c6050
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const result = run(['understand'], { cwd: repo }); | ||
| assertIncludes(result.stdout, 'Codra Understand', 'understand output'); |
There was a problem hiding this comment.
This new smoke test calls codra understand, but the reviewed tree has no understand subcommand in crates/codra-cli/src/main.rs and git grep only finds this test expectation. The wrapper therefore prints the normal help for an unknown command, so npm test fails at the Codra Understand assertion before the release workflow can package the CLI.
Useful? React with 👍 / 👎.
| const dryRun = spawnSync('npm', ['pack', '--dry-run'], { | ||
| cwd: packageRoot, | ||
| encoding: 'utf8', | ||
| env: process.env, | ||
| }); |
There was a problem hiding this comment.
In the release workflow's Test npm wrapper step, the environment only sets CODRA_USE_ARTIFACTS, while the default matrix intentionally omits darwin-x64. This new npm pack --dry-run invokes prepack; without CODRA_EXPECT_PLATFORMS/CODRA_ALLOW_PARTIAL_BINARIES, build-platform-binaries.js falls back to requiring all five artifacts, including the unbuilt codra-darwin-x64, so the default release workflow fails even after artifacts were packaged successfully in the previous step.
Useful? React with 👍 / 👎.
| crossterm = "0.28" | ||
| ratatui = "0.29" |
There was a problem hiding this comment.
These dependencies were added without updating Cargo.lock; the reviewed lockfile still has no crossterm or ratatui package entries. Since cargo build --help defines --locked as asserting that Cargo.lock remains unchanged, any locked/reproducible build of this repo will fail before compilation until the regenerated lockfile is committed with the manifest change.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| const tarball = path.join(packageRoot, match[1]); | ||
| const install = spawnSync('npm', ['install', '-g', tarball], { |
There was a problem hiding this comment.
When npm test runs on a developer machine or shared CI image, this npm install -g uses the real global prefix (npm install --help lists -g|--global) and never uninstalls it. That can fail if another package already owns the codra shim or leave this tarball as the user's global codra, so use a temporary --prefix/sandboxed install for the version check instead.
Useful? React with 👍 / 👎.
1 participant
No description provided.