fix(spinner): suppress ANSI output when stderr is not a terminal#3758
Open
KooshaPari wants to merge 1 commit into
Open
fix(spinner): suppress ANSI output when stderr is not a terminal#3758KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
Detects is_terminal at SpinnerManager construction. When stderr is not a TTY (piped, redirected, or -p prompt mode), the spinner thread is never started and write_ln/ewrite_ln emit plain text only. Fixes tailcallhq#3615.
|
KooshaPari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3615
When
forge -pis used or output is piped/redirected, the spinner thread writes ANSI escape codes (\r\x1b[2K) to stderr, polluting non-TTY output. This PR adds terminal detection so the spinner is only created when stderr is an actual terminal.Changes
std::io::IsTerminalimportis_terminal: boolfield toSpinnerManager, auto-detected innew()viastd::io::stderr().is_terminal()start()returnsNone(no spinner thread) when!is_terminalforce_terminal()test helper (cfg(test)only) to allow unit tests to exercise spinner logic in non-TTY environmentscargo checkcleanTest plan
cargo check -p forge_spinner— 0 errorscargo test -p forge_spinner— 10/10 passforge -p "hello" 2>/dev/null— no ANSI in stdoutforge -p "hello" | cat— clean output