Skip to content

chore(angular): remove provideAnimationsAsync usage from angular integration app - #8351

Open
myrta2302 wants to merge 2 commits into
mainfrom
remove-provideAnimationsAsync-from-angular-app
Open

chore(angular): remove provideAnimationsAsync usage from angular integration app#8351
myrta2302 wants to merge 2 commits into
mainfrom
remove-provideAnimationsAsync-from-angular-app

Conversation

@myrta2302

@myrta2302 myrta2302 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

📄 Description

This PR removes the usage of provideAnimationsAsync from the Angular app and eliminates the dependency on @angular/animations that was only required for it. (Tested Primeng and seems to work fine without it.)

This also fixes the E2E failure introduced by pnpm 11 update, which no longer installs the optional peer dependency providing @angular/animations/browser.

Tested this PR by merging it to the failing one and now it passes.

🔮 Design review

  • Design review done
  • No design review needed

🧪 Visual regression tests

  • Visual changes detected and approved (Check this box if VRT fails and changes are intentional)

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@changeset-bot

changeset-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e166467

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myrta2302
myrta2302 marked this pull request as ready for review August 21, 2026 10:53
@myrta2302
myrta2302 requested a review from a team as a code owner August 21, 2026 10:53
@sonarqubecloud

Copy link
Copy Markdown

@myrta2302
myrta2302 requested review from alizedebray and removed request for oliverschuerch August 21, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant