Fix: Add Sandbox to Image Headers - #7174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, SVG images were not sandboxed so they could run embedded scripts within Stash context. This adds a sandbox and various other verification steps to prevent this from happening but still allow SVGs to be used as images within stash.
Related Issue
N/A
Testing
Dev tests were completed
Curl example with my own "malicious" svg. The SVG is injected with some malicious code but the script is not ran. The images still loads appropriatly
Screenshots
NA
Checklist
AI Usage Disclosure
Claude Opus was used to help build the test and the malicious test SVG.
Additional Context
Thanks to Nynxz for reporting this!!