New: Fingerprint Submission Queue (Batching) - #6986
Draft
Gykes wants to merge 3 commits into
Draft
Conversation
Collaborator
|
Is this not already superceded by #6782? |
Collaborator
Author
|
No, their version was done before the new stashbox batch submission were put into place. That one is also a lot more verboose and was a refactor of various other things. Mine is more pointed to a specific pain point without doing a whole refactor. |
Gykes
marked this pull request as draft
June 4, 2026 15:41
Collaborator
Author
|
Converting to draft as I need to add batch size and timeout configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been a long standing issue that, when you have a lot of fingerprints, it runs longer than the timeout then they get lost/removed and not submitted. This iteration of this fix modifies the fingerprint submission to use the new StashBox submission mutation. Currently it is hard coded at 50 at a time. If someone could educate me on a better number, as 50 is arbitrary, then I would love to see the science behind it and we can raise/lower the limit as needed. I think in the future we could make this variable an option in the UI that allows users to increase/decrease as they see fit.
Testing done (not too much):
Sadly I don't have an ass load of fingerprints in my dev version that I can do this with and i'm not too sure how to do it. I could potentially copy over my 50k or so fingerprints from my main machine. I guess we can see if the code is any good and I can run that if needed.