Add 'aliases' filter to Group (GraphQL, backend, tests, and UI) - #6896
Open
slick-daddy wants to merge 8 commits into
Open
Add 'aliases' filter to Group (GraphQL, backend, tests, and UI)#6896slick-daddy wants to merge 8 commits into
slick-daddy wants to merge 8 commits into
Conversation
8 tasks
Collaborator
|
I think this one should wait until #6951 lands. |
Add 'aliases' filter to Group (GraphQL, backend, tests, and UI)
The previous value 'oup_0001_A' was a magic offset substring of 'group_0001_Aliases' (positions 2-12). Changed to '0001_Ali' (positions 6-14) which starts at a natural boundary after the 'group_' prefix, making it immediately obvious it's a substring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4383
Motivation
Description
aliases: StringCriterionInputto the GraphQLGroupFilterTypeinfilters.graphql.Aliases *StringCriterionInputto the Gomodels.GroupFilterTypeand wired astringCriterionHandlerforgroups.aliasesin the SQLite group filter handler.TestGroupQueryAliasesinpkg/sqlite/group_test.goto validate alias filtering with multiple criterion modifiers.aliasesin the UI list filter options by addingcreateStringCriterionOption("aliases")inui/v2.5/src/models/list-filter/groups.ts.