Skip to content

Bump sn-forge 0.59 -> 0.63 & scarb 2.15.1 -> 2.18.0 - #185

Merged
remollemo merged 3 commits into
mainfrom
remo/tools/bump
Aug 17, 2026
Merged

Bump sn-forge 0.59 -> 0.63 & scarb 2.15.1 -> 2.18.0#185
remollemo merged 3 commits into
mainfrom
remo/tools/bump

Conversation

@remollemo

@remollemo remollemo commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@remollemo remollemo self-assigned this Aug 17, 2026
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

PR Summary

High Risk
Changes governance-style delayed execution semantics, public interfaces (salt parameter), and multisig timer/deadline behavior—integrators and deployed callers must update calldata and expectations.

Overview
Toolchain: CI, .tool-versions, and workspace deps move to Scarb 2.18.0 and starknet-foundry 0.63.0 (plus voyager in asdf). Account package test class hashes and EIP-712 fixture signatures are refreshed for the new compiler.

Delayed executor — breaking API: submit_calls / exec_calls now take a salt; call-set keys are poseidon(serialize(calls) ++ [salt]), so identical batches can be queued concurrently with different salts (0 is the usual default).

Submission semantics: DelayedExecutor no longer treats re-submit while Pending/Ready as a no-op — it reverts with ALREADY_SUBMITTED. MultiExecutor reverts ALREADY_SIGNED_BY_CALLER instead of idempotent return (slot-based, including inherited signatures after ownership transfer).

MultiExecutor timers: Delay timer is write-once (retracting below threshold does not reset it; only full withdrawal to zero clears timers). Expiration is set on first signature and re-anchored once at the first threshold crossing, emitting CallSetTimerStarted. Constructor requires execution_expiration > execution_delay (EXPIRATION_BELOW_DELAY).

Other: MultiOwned rejects the contract’s own address as an owner (SELF_AS_OWNER). DelayedExecutor returns real allowed_time for Expired sets. SPEC.md documents the new behavior.

Reviewed by Cursor Bugbot for commit 9d39729. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6272e6b. Configure here.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.82047% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8974d02). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ages/delayed_executor/tests/test_multi_owned.cairo 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage        ?   97.50%           
=======================================
  Files           ?       88           
  Lines           ?     7301           
  Branches        ?        0           
=======================================
  Hits            ?     7119           
  Misses          ?      182           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@remollemo remollemo changed the title Bump sn-forge 0.59 -> 0.63 & scarb 2.15.1 -> 2.18.0 (external reasons - using of Primer in other repos) Bump sn-forge 0.59 -> 0.63 & scarb 2.15.1 -> 2.18.0 Aug 17, 2026
@starkware-libs starkware-libs deleted a comment from cursor Bot Aug 17, 2026

@noa-starkware noa-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noa-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on remollemo).

@remollemo remollemo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remollemo reviewed 7 files and all commit messages.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on remollemo).

@remollemo remollemo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remollemo reviewed 8 files and all commit messages.
Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on remollemo).

@remollemo
remollemo merged commit 3e2fd53 into main Aug 17, 2026
3 of 4 checks passed
@remollemo
remollemo deleted the remo/tools/bump branch August 17, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants