fix(discovery): restore cursor after boundary finding - #901
Open
Gaijin-01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
cursor.last_note_index = Some(boundary)after bisection completes infind_last_note_index(), so that the nextdiscover_notes_paginated()call resumes linear scan from the correct position instead of re-scanning already-filtered notes from the beginning.Root cause
find_last_note_index()persistedtotal_n_notesvia bisection but omitted the correspondinglast_note_indexassignment. On the nextdiscover_notes_paginated()call,cursor.start_index()returned 0, causing already-filtered notes to be re-scanned — wasting IO budget and leaking access patterns via repeated RPC calls to the same note indices.Solution
Add
cursor.last_note_index = Some(boundary)after bisection completes. On the next call,start_index() = boundary + 1, resuming linear scan at the correct position without re-probing already-filtered notes.Validation
test_find_last_note_index_sets_cursor_last_note_index.Scope
crates/discovery-core/src/discovery/last_note_index.rs.References
crates/discovery-core/src/discovery/last_note_index.rsThis change is