Skip to content

fix: fake client targeting and harden client state resets #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 1 commit into from
Jul 27, 2026
Merged

fix: fake client targeting and harden client state resets #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions addons/sourcemod/scripting/ThirdPerson.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public Plugin myinfo =
name = "ThirdPerson",
author = "BotoX, maxime1907, .Rushaway",
description = "Allow players/admins to toggle thirdperson on themselves/players.",
version = "1.3.5"
version = "1.3.6"
}

public APLRes AskPluginLoad2(Handle myself, bool late, char[] error, int err_max)
Expand Down Expand Up @@ -106,6 +106,12 @@ public void OnClientPutInServer(int client)
g_bMirror[client] = false;
}

public void OnClientDisconnect(int client)
{
g_bThirdPerson[client] = false;
g_bMirror[client] = false;
}

public void Event_RoundStart(Event event, const char[] name, bool dontBroadcast)
{
g_bZombieSpawned = false;
Expand Down Expand Up @@ -168,7 +174,7 @@ public Action Command_ThirdPerson(int client, int args)
public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast)
{
int client = GetClientOfUserId(GetEventInt(event, "userid"));
if (IsValidClient(client, true, false) && g_bThirdPerson[client] || g_bMirror[client])
if (IsValidClient(client, true, false) && (g_bThirdPerson[client] || g_bMirror[client]))
Comment thread
Rushaway marked this conversation as resolved.
{
int attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
if (g_bZombieReloaded && IsValidClient(attacker, false))
Expand Down Expand Up @@ -198,7 +204,7 @@ public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadca
public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast)
{
int client = GetClientOfUserId(GetEventInt(event, "userid"));
if (IsValidClient(client))
if (IsValidClient(client, true))
{
Comment thread
Rushaway marked this conversation as resolved.
ResetClient(client);
}
Expand Down