feat(api): Add GetClientIP method to keep track of connected clients. - #4
Merged
Conversation
Dolly132
added a commit
to Dolly132/sm-plugin-SMJSONAPI
that referenced
this pull request
Jul 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds client IP tracking to the AsyncSocket SourceMod extension so plugins can identify the remote peer (primarily for server-accepted connections) and apply allow/deny logic (e.g., whitelisting).
Changes:
- Added
m_pClientIPtoCAsyncSocketContextandpClientIPtoCSocketConnect, including cleanup/free logic. - Captured the peer IP on new inbound connections (
uv_tcp_getpeername+uv_ip*_name) and propagated it onto the created socket context. - Exposed a new SourcePawn native
AsyncSocket.GetClientIP()and added it to the.incmethodmap.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/extension.h |
Extends the connect-queue payload to carry a client IP pointer. |
src/extension.cpp |
Captures peer IP on accept, stores it on socket contexts, adds AsyncSocket.GetClientIP native, and frees stored IPs on teardown. |
src/context.h |
Adds m_pClientIP to the socket context. |
src/context.cpp |
Initializes and frees m_pClientIP in the context lifecycle. |
package/addons/sourcemod/scripting/include/AsyncSocket.inc |
Adds GetClientIP() to the SourcePawn-facing API surface. |
Comments suppressed due to low confidence (1)
src/extension.cpp:140
- Indentation here uses spaces instead of the tab indentation used elsewhere in this file, and the braces are misaligned with the surrounding style.
if (pConnect->pClientIP)
{
pConnect->pSocketContext->m_pClientIP = pConnect->pClientIP;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For security reasons, it is mandatory to check who is trying to connect to the socket server
therefore, I added a new method to identify the ip of the client that connects to the server.
Should help in blocking traffic coming from non-whitelisted ips (Used in SMJSONAPI plugin)