fix: copy /system/providers/ from stylus image to support stylus v4.10.x on kubeadm nodes - #737
Open
birendrasingh7698 wants to merge 1 commit into
Open
fix: copy /system/providers/ from stylus image to support stylus v4.10.x on kubeadm nodes#737birendrasingh7698 wants to merge 1 commit into
birendrasingh7698 wants to merge 1 commit into
Conversation
…0.x kubeadm provider stylus v4.10.x introduced agent-provider-kubeadm which it expects to find in /system/providers/ at cluster creation time. Without this the runtime upgrade rsync tries to write agent-provider-kubeadm to /system/providers/ which is a read-only partition at runtime, causing cluster creation to hang indefinitely at the 'Upgrading provider image' stage on kubeadm nodes. The --if-exists flag is backward-compatible: on stylus v4.9.x where /system/providers/ in the stylus image only contains agent-provider-stylus (already placed by the kairos-provider-image copy), this is a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When building AI Launchpad ISO with stylus
v4.10.x(dev channel), cluster creation hangs indefinitely at Upgrading provider image with this error repeating every ~5s:Root cause: stylus
v4.10.xshipsagent-provider-kubeadmin/system/providers/of the stylus-framework image and expects it to be present there at cluster creation time. The current Earthfile copies specific files from the stylus image (branding, config, etc.) but not/system/providers/. At runtime, stylus tries to writeagent-provider-kubeadmto/system/providers/via content rsync — but that partition is read-only.Confirmed:
v4.9.34): works —agent-provider-kubeadmnot requiredv4.10.0-260805): broken — stuck at provider upgradeFix
Add one line to copy
/system/providers/from the stylus framework image into the ISO. The--if-existsflag makes this backward-compatible: on stylusv4.9.xthis is a no-op since onlyagent-provider-stylusis there (already placed by the kairos-provider-image copy).Testing
Trigger
On-Demand Slim ISO Buildwithchannel=dev,data_ref=main, flash on a GPU node, confirm cluster creation completes past Upgrading provider image.