fix: new dace.math.atan2 requires two arguments#2435
Open
romanc wants to merge 2 commits into
Open
Conversation
`std::atan2` exposed as `dace.math.atan2` computes the arc tangent of `y / x` and thus requires two arguments.
romanc
changed the title
dace.math.atan2 requires two arguments
ThrudPrimrose
approved these changes
Jul 13, 2026
ThrudPrimrose
left a comment
ThrudPrimrose
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
(We need to consider having a codegen + numerical correctness tests for all intrinsics we provide in dace runtime later)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick follow-up from #2418.
std::atan2exposed asdace.math.atan2computes the arc tangent ofy / xand thus requires two arguments.