Fix Y2038 netlink sequence number in libbpf - #606
Open
subharam-cisco wants to merge 1 commit into
Open
Conversation
|
|
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Subhasri-Ramasamy <subharam@cisco.com>
subharam-cisco
force-pushed
the
fix/y2038-libbpf-netlink-seq
branch
from
August 7, 2026 07:18
8822735 to
5750313
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
paulmenzel
suggested changes
Aug 7, 2026
paulmenzel
left a comment
paulmenzel
left a comment
Contributor
There was a problem hiding this comment.
Please send the patch to Linux upstream for review.
| @@ -0,0 +1,48 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: SONiC Build <build@sonic.net> | |||
| should be monotonically increasing; a timestamp is unnecessary. Use a | ||
| static counter instead and drop the unused time.h include. | ||
|
|
||
| Signed-off-by: SONiC Build <build@sonic.net> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace time(NULL) with a static monotonic counter in libbpf_netlink_send_recv() to avoid truncating 64-bit time_t into the 32-bit nlmsg_seq field.