Skip to content

fix(textures): default createImageBitmapSupport to 'auto' so Chrome 38 doesn't throw #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiefcll merged 1 commit into from
Jul 17, 2026
Merged

fix(textures): default createImageBitmapSupport to 'auto' so Chrome 38 doesn't throw #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/main-api/Renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,13 +630,17 @@ export type RendererMainSettings = RendererRuntimeSettings & {
* - Full - Supports createImageBitmap(image, sx, sy, sw, sh, options)
*
* Note with auto detection, the renderer will attempt to use the most advanced
* version of the API available. If the API is not available, the renderer will
* fall back to the next available version.
* version of the API available. If the API is not available (e.g. Chrome < 50,
* including the Chrome 38 support floor), the renderer falls back to loading
* images via `new Image()`.
*
* This will affect startup performance as the renderer will need to determine
* the supported version of the API.
* `'auto'` runs a small startup probe (a 1x1 PNG) to determine support; this
* adds a negligible one-time startup cost. Set an explicit value (`'full'`,
* `'options'`, `'basic'`) to skip the probe ONLY when the target runtime is
* known to support that level — forcing a level the runtime lacks will fail
* to load images. When in doubt, use `'auto'`.
*
* @defaultValue `full`
* @defaultValue `auto`
*/
createImageBitmapSupport: 'auto' | 'basic' | 'options' | 'full';

Expand Down Expand Up @@ -816,7 +820,7 @@ export class RendererMain extends EventEmitter {
textBaselineMode: settings.textBaselineMode ?? 'optical',
textureProcessingTimeLimit: settings.textureProcessingTimeLimit || 10,
canvas: settings.canvas,
createImageBitmapSupport: settings.createImageBitmapSupport || 'full',
createImageBitmapSupport: settings.createImageBitmapSupport || 'auto',
// undefined -> true (assume honored, no probe); 'auto' -> probe;
// explicit boolean -> force the value.
premultiplyAlphaHonored:
Expand Down
Loading