Remove redundant service name in api - #1306
Open
aureamunoz wants to merge 1 commit into
Open
Conversation
aureamunoz
force-pushed
the
improve-api-registration-issue-1253-v3
branch
from
July 13, 2026 13:28
54b45c0 to
97555ca
Compare
aureamunoz
marked this pull request as ready for review
July 13, 2026 13:33
cescoffier
requested changes
Jul 15, 2026
cescoffier
left a comment
cescoffier
left a comment
Contributor
There was a problem hiding this comment.
I spotted something in the test, the rest looks good.
aureamunoz
force-pushed
the
improve-api-registration-issue-1253-v3
branch
2 times, most recently
from
July 15, 2026 12:59
6b3c151 to
18cddaa
Compare
cescoffier
requested changes
Jul 16, 2026
aureamunoz
force-pushed
the
improve-api-registration-issue-1253-v3
branch
from
July 16, 2026 12:41
18cddaa to
0d754b4
Compare
refactor according review format files
aureamunoz
force-pushed
the
improve-api-registration-issue-1253-v3
branch
from
July 17, 2026 06:27
0d754b4 to
cf40641
Compare
cescoffier
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code review here: #1254