fix: carry every odometer digit on the middle of its slot - #86
Open
sjquant wants to merge 1 commit into
Open
Conversation
An odometer reserves one fixed-width slot per digit so a growing number cannot shift sideways as it counts. Each digit was then set against the left edge of its slot, which puts the whole reserve on one side: in a display face whose 1 is far narrower than its widest digit, 148 reads as 1 48 with a hole in the middle of the number. A wheel carries its digit in the middle, so the reserve is split. Slot widths and the block's total width are untouched, so the stability the slots exist for is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An odometer reserves one fixed-width slot per digit so a growing number cannot shift sideways as it counts. Each digit was then set against the left edge of its slot, which puts the whole reserve on one side. In a display face whose
1is far narrower than its widest digit,148reads as1 48— a hole in the middle of the number.Changes