Save As: treat the active project as a save, not an overwrite - #266
Open
alex-rawlings-yyc wants to merge 1 commit into
Open
Save As: treat the active project as a save, not an overwrite#266alex-rawlings-yyc wants to merge 1 commit into
alex-rawlings-yyc wants to merge 1 commit into
Conversation
Overwriting the project the draft is already open on is the same write the Save command performs, so the destructive confirmation was warning about a risk that isn't there. That row now reads Save, writes on the first press, and skips the confirmation entirely; the other rows keep the Overwrite label and its red confirm. A draft with nothing unsaved would write nothing at all, so the active row reports that instead of offering the save, and withdraws the button if an autosave lands while the dialog is open. Without a confirmation in front of it, the button's disabled state is the only thing blocking a double-click from writing twice, so that is now covered by a test.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwriting the project the draft is already open on is the same write the Save command performs, so the destructive confirmation was warning about a risk that isn't there. That row now reads Save, writes on the first press, and skips the confirmation entirely; the other rows keep the Overwrite label and its red confirm.
A draft with nothing unsaved would write nothing at all, so the active row reports that instead of offering the save, and withdraws the button if an autosave lands while the dialog is open.
Without a confirmation in front of it, the button's disabled state is the only thing blocking a double-click from writing twice, so that is now covered by a test.
This change is