Skip to content

Save As: treat the active project as a save, not an overwrite - #266

Open
alex-rawlings-yyc wants to merge 1 commit into
mainfrom
199-save-as-overwrite-active-project
Open

Save As: treat the active project as a save, not an overwrite#266
alex-rawlings-yyc wants to merge 1 commit into
mainfrom
199-save-as-overwrite-active-project

Conversation

@alex-rawlings-yyc

@alex-rawlings-yyc alex-rawlings-yyc commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Overwriting the project the draft is already open on is the same write the Save command performs, so the destructive confirmation was warning about a risk that isn't there. That row now reads Save, writes on the first press, and skips the confirmation entirely; the other rows keep the Overwrite label and its red confirm.

A draft with nothing unsaved would write nothing at all, so the active row reports that instead of offering the save, and withdraws the button if an autosave lands while the dialog is open.

Without a confirmation in front of it, the button's disabled state is the only thing blocking a double-click from writing twice, so that is now covered by a test.


This change is Reviewable

Overwriting the project the draft is already open on is the same write
the Save command performs, so the destructive confirmation was warning
about a risk that isn't there. That row now reads Save, writes on the
first press, and skips the confirmation entirely; the other rows keep
the Overwrite label and its red confirm.

A draft with nothing unsaved would write nothing at all, so the active
row reports that instead of offering the save, and withdraws the button
if an autosave lands while the dialog is open.

Without a confirmation in front of it, the button's disabled state is
the only thing blocking a double-click from writing twice, so that is
now covered by a test.
@alex-rawlings-yyc alex-rawlings-yyc self-assigned this Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 76dba671-3e77-41b9-92f9-ad25dfa98ed1


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alex-rawlings-yyc alex-rawlings-yyc linked an issue Aug 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve save-as overwrite of active project

1 participant