Add created/modified timestamps to analyses

[alex-rawlings-yyc]

This change is 

Summary by CodeRabbit

• New Features

  • Added creation and modification timestamps to analysis records and links.
  • Timestamps now update consistently when analyses are created, edited, approved, shared, forked, or removed.
  • Older saved projects and drafts receive fallback timestamps when needed.

• Bug Fixes

  • Preserved existing timestamps during data loading and migration.
  • Clarified that timestamps do not affect analysis identity.

• Tests

  • Added comprehensive coverage for timestamp creation, updates, preservation, and fallback behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 96ba6496-d366-4af1-92b4-659f6447a8d5

📥 Commits

Reviewing files that changed from the base of the PR and between 382a02c and 9897ebe.

📒 Files selected for processing (2)

• src/__tests__/services/projectStorage.test.ts
• src/services/projectStorage.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• src/tests/services/projectStorage.test.ts
• src/services/projectStorage.ts

---

📝 Walkthrough

Walkthrough

Analysis records and links now include createdAt and updatedAt. Reducer operations create and update these values. Project and draft reads backfill missing timestamps. Tests use deterministic fixtures and cover timestamp behavior.

Changes

Analysis timestamp support

Layer / File(s)	Summary
Timestamp contracts and legacy backfill src/types/interlinearizer.d.ts, src/utils/analysis-timestamps.ts, src/utils/analysis-identity.ts, src/__tests__/utils/*	Analysis records and links define timestamps. Missing timestamps receive fallback values. Timestamp fields remain excluded from analysis identity.
Reducer timestamp propagation src/store/analysisSlice.ts	Prepared actions generate timestamps for token, phrase, segment, morpheme, approval, fork, and merge operations.
Persistence read compatibility src/services/projectStorage.ts, src/__tests__/services/projectStorage.test.ts	Project and draft reads backfill missing timestamps. Repaired drafts are persisted without hiding read results when persistence fails.
Timestamp regression coverage src/__tests__/store/analysisSlice.test.ts	Tests cover creation, edits, sharing, forks, approvals, phrase updates, segment translations, and morpheme changes.
Timestamped test fixtures src/__tests__/components/*, src/__tests__/hooks/useDraftProject.test.ts, src/__tests__/utils/*, src/__tests__/test-helpers.ts	Existing analysis and link fixtures now include shared deterministic timestamp fields.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Editor
  participant analysisSlice
  participant projectStorage
  participant AnalysisData
  Editor->>analysisSlice: dispatch prepared analysis action
  analysisSlice->>AnalysisData: create or update record and link timestamps
  projectStorage->>AnalysisData: read persisted project or draft
  projectStorage->>AnalysisData: backfill missing timestamps

Loading

Possibly related PRs

• sillsdev/interlinearizer-extension#153: Both PRs modify projectStorage.ts and timestamp persistence tests.

Suggested reviewers: imnasnainaec

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding creation and modification timestamps to analyses.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 185-analysis-timestamps

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[alex-rawlings-yyc]

@alex-rawlings-yyc resolved 1 discussion.
Reviewable status: 0 of 20 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).

[imnasnainaec]

Review pass over the analysis-timestamp work, against 2407b86. Nothing blocking: one behavior regression in getProject, one stability improvement in getDraft, and three documentation notes. Verified locally — 1663 tests pass at 100% coverage.

— Claude Opus 5 (inspired by Devin)

[alex-rawlings-yyc]

@alex-rawlings-yyc made 5 comments.
Reviewable status: 0 of 21 files reviewed, 5 unresolved discussions (waiting on alex-rawlings-yyc and imnasnainaec).

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/services/projectStorage.ts`:
- Around line 633-637: Update the draft backfill flow around getDraft and
backfillAnalysisTimestamps so the read, timestamp mutation, and conditional
direct storage write execute within a single enqueueSerialized(draftQueues,
sourceProjectId, ...) operation. Replace the nested saveDraft call with the
appropriate direct persistence step inside that serialized callback, preserving
the existing error logging and avoiding a second queue submission.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4aa45d78-ac4a-4f97-b33e-d1a47bd39a75

📥 Commits

Reviewing files that changed from the base of the PR and between dbfc9ae and 382a02c.

📒 Files selected for processing (9)

• src/__tests__/services/projectStorage.test.ts
• src/__tests__/utils/analysis-identity.test.ts
• src/__tests__/utils/analysis-timestamps.test.ts
• src/__tests__/utils/suggestion-engine.test.ts
• src/services/projectStorage.ts
• src/store/analysisSlice.ts
• src/types/interlinearizer.d.ts
• src/types/type-guards.ts
• src/utils/analysis-timestamps.ts

🚧 Files skipped from review as they are similar to previous changes (5)

• src/tests/utils/analysis-identity.test.ts
• src/types/interlinearizer.d.ts
• src/tests/utils/analysis-timestamps.test.ts
• src/tests/utils/suggestion-engine.test.ts
• src/store/analysisSlice.ts

[alex-rawlings-yyc]

@alex-rawlings-yyc made 1 comment.
Reviewable status: 0 of 21 files reviewed, 6 unresolved discussions (waiting on alex-rawlings-yyc and imnasnainaec).

[imnasnainaec]

@imnasnainaec partially reviewed 15 files, made 1 comment, and resolved 5 discussions.
Reviewable status: 14 of 21 files reviewed, 2 unresolved discussions (waiting on alex-rawlings-yyc).

---

src/utils/analysis-timestamps.ts at r5 (raw file):
❓ I'm pondering if we even need to handle legacy analyses. We haven't even done a fully public release. It'd be simpler if we can just enforce fully stamped now.

[alex-rawlings-yyc]

src/utils/analysis-timestamps.ts at r5 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

❓ I'm pondering if we even need to handle legacy analyses. We haven't even done a fully public release. It'd be simpler if we can just enforce fully stamped now.

That's what my initial thought was, but I figured it would be better to be safer to handle them by default and strip away legacy handling later if we decided it wasn't necessary. Since it exists already I'm fine with it, but I think I would really prefer if we didn't have code that handled legacy analyses

[imnasnainaec]

@imnasnainaec reviewed 7 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).