Conversation
ViewDefinitionOverrideApplier rebuilds every node when it applies a patch, but its CloneWith and CloneWithId helpers stopped short of the ViewNode constructor's last three optional parameters. Omitting them let the defaults win, so EnumStringList, VisibleWritingSystems and ToggleValue were stripped from the whole tree as soon as a project carried any override -- a single SetVisibility operation was enough. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 38.31% 38.33% +0.01%
==========================================
Files 1507 1507
Lines 350524 350554 +30
Branches 40288 40291 +3
==========================================
+ Hits 134310 134385 +75
+ Misses 186983 186939 -44
+ Partials 29231 29230 -1
🚀 New features to boost your workflow:
|
|
and aren't covered by the EmptyPatch test Code quote: // any override exists. These three fields are outside ToSnapshot(), so the empty-patch
// test misses it. |
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on jasonleenaylor).
Src/Common/FwAvalonia/FwAvaloniaTests/ViewDefinitionOverrideApplierTests.cs line 46 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
and aren't covered by the EmptyPatch test
I change the comment.
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
ViewDefinitionOverrideApplier rebuilds every node when it applies a patch, but its CloneWith and CloneWithId helpers stopped short of the ViewNode constructor's last three optional parameters. Omitting them let the defaults win, so EnumStringList, VisibleWritingSystems and ToggleValue were stripped from the whole tree as soon as a project carried any override -- a single SetVisibility operation was enough.
This change is