Skip to content

Polish Commit Template Checklist - #1081

Merged
papeh merged 2 commits into
mainfrom
feature/polish-commit-template
Aug 20, 2026
Merged

Polish Commit Template Checklist#1081
papeh merged 2 commits into
mainfrom
feature/polish-commit-template

Conversation

@papeh

@papeh papeh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
  • Remove check for whitespace: this is redundant to automatic checks
  • Add a step to self-review with AI per our team decision
  • Increase minimum commit message title length to 8 characters

sillsdev/fwmeta#1 aligns expectations for commit messages in our commit hook to those in .github/commit-guidelines.md

CI-ready checklist


This change is Reviewable

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   8m 39s ⏱️ -39s
5 799 tests ±0  5 718 ✅ ±0  81 💤 ±0  0 ❌ ±0 
5 808 runs  ±0  5 727 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit 69df12a. ± Comparison against base commit 0c05d3d.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.28%. Comparing base (0c05d3d) to head (69df12a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1081   +/-   ##
=======================================
  Coverage   38.28%   38.28%           
=======================================
  Files        1499     1499           
  Lines      350230   350230           
  Branches    40261    40261           
=======================================
+ Hits       134096   134100    +4     
+ Misses     186915   186912    -3     
+ Partials    29219    29218    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

papeh added 2 commits August 19, 2026 16:55
* Remove check for whitespace: this is redundant to automatic checks
* Add a step to self-review with AI per our team decision

TODO: ensure commit message line length guidelines match commit hooks
* Add gitlint rule to enforce minimum 8-character title lines
@papeh
papeh force-pushed the feature/polish-commit-template branch from 7a33cde to 69df12a Compare August 19, 2026 21:56
@papeh
papeh marked this pull request as ready for review August 19, 2026 22:04
@papeh papeh changed the title Polish Commit Message Checklist Polish Commit Template Checklist Aug 19, 2026

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@thejambi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on papeh).

@papeh
papeh merged commit 890dc74 into main Aug 20, 2026
9 checks passed
@papeh
papeh deleted the feature/polish-commit-template branch August 20, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants