Skip to content

Fix LT-22649 - #1080

Merged
AndyBlack merged 2 commits into
mainfrom
LT22649
Aug 19, 2026
Merged

Fix LT-22649#1080
AndyBlack merged 2 commits into
mainfrom
LT22649

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Both PcPatr with FLEx and TonePars with FLEx added new unowned lists (as well as some custom fields). They never broadcast this fact, though. This code fixes that (and does some cleanup, too).
It also fixes the crashes reported in https://jira.sil.org/browse/LT-22649.

It is basically just adding a PropertyTable instance so we can publish the change via
FwUtils.Publisher.Publish(new PublisherParameterObject(EventConstants.MasterRefresh, null, PropTable.GetWindow()));


This change is Reviewable

Change-Id: I98bb549c5b8eff9c10e3abbb92feea7d685452d9
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files      1 suites   7m 45s ⏱️
5 799 tests 5 718 ✅ 81 💤 0 ❌
5 808 runs  5 727 ✅ 81 💤 0 ❌

Results for commit 70f4b91.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.28%. Comparing base (b857373) to head (70f4b91).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...ies/pcpatrflex/ToneParsFLExDll/ToneParsFLExForm.cs 0.00% 2 Missing ⚠️
...tilities/pcpatrflex/ToneParsFLExDll/FLExUtility.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   38.04%   38.28%   +0.24%     
==========================================
  Files        1499     1499              
  Lines      350117   350238     +121     
  Branches    40233    40261      +28     
==========================================
+ Hits       133196   134104     +908     
+ Misses     187634   186915     -719     
+ Partials    29287    29219      -68     
Files with missing lines Coverage Δ
Src/Utilities/pcpatrflex/PrepFLExDBDll/Preparer.cs 98.11% <100.00%> (+0.03%) ⬆️
...tilities/pcpatrflex/ToneParsFLExDll/FLExUtility.cs 0.00% <0.00%> (ø)
...ies/pcpatrflex/ToneParsFLExDll/ToneParsFLExForm.cs 0.00% <0.00%> (ø)

... and 149 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@papeh

papeh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

There may be some overlap between this and #1075

@papeh papeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but tests should dispose their disposables.

Comment thread Src/Utilities/pcpatrflex/PcPatrFLExDll/PcPatrFLExForm.cs
Comment thread Src/Utilities/pcpatrflex/PrepFLExDBDll/PrepFLExDBTests/PreparerTests.cs Outdated
Comment thread Src/Utilities/pcpatrflex/PrepFLExDBDll/PrepFLExDBTests/PreparerTests.cs Outdated
Comment thread Src/Utilities/pcpatrflex/PrepFLExDBDll/PrepFLExDBTests/PreparerTests.cs Outdated
@AndyBlack

Copy link
Copy Markdown
Collaborator Author

There may be some overlap between this and #1075

Ah, I was not aware of Jason doing this. I'll happily wait until that PR is merged. When it is, I'll see if it solves the crashes for https://jira.sil.org/browse/LT-22649 and https://jira.sil.org/browse/LT-22708.
Also, thanks for noticing the other issues, Hasso. I'll address them as needed later.

Change-Id: I45408f2ff0027aeb04040f0da43feb6e833f874e
@AndyBlack
AndyBlack merged commit f0de1ed into main Aug 19, 2026
8 of 9 checks passed
@AndyBlack
AndyBlack deleted the LT22649 branch August 19, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants