Conversation
Change-Id: I98bb549c5b8eff9c10e3abbb92feea7d685452d9
NUnit Tests 1 files 1 suites 7m 45s ⏱️ Results for commit 70f4b91. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 38.04% 38.28% +0.24%
==========================================
Files 1499 1499
Lines 350117 350238 +121
Branches 40233 40261 +28
==========================================
+ Hits 133196 134104 +908
+ Misses 187634 186915 -719
+ Partials 29287 29219 -68
🚀 New features to boost your workflow:
|
|
There may be some overlap between this and #1075 |
papeh
left a comment
There was a problem hiding this comment.
Looks good overall, but tests should dispose their disposables.
Ah, I was not aware of Jason doing this. I'll happily wait until that PR is merged. When it is, I'll see if it solves the crashes for https://jira.sil.org/browse/LT-22649 and https://jira.sil.org/browse/LT-22708. |
Change-Id: I45408f2ff0027aeb04040f0da43feb6e833f874e
Both PcPatr with FLEx and TonePars with FLEx added new unowned lists (as well as some custom fields). They never broadcast this fact, though. This code fixes that (and does some cleanup, too).
It also fixes the crashes reported in https://jira.sil.org/browse/LT-22649.
It is basically just adding a PropertyTable instance so we can publish the change via
FwUtils.Publisher.Publish(new PublisherParameterObject(EventConstants.MasterRefresh, null, PropTable.GetWindow()));This change is