Clean up Setup-Developer-Machine.ps1 and set $env:LcmRootDir - #1077
Merged
Conversation
* Remove the junction to LCMRepo--it is located by an environment var * Check for LibLCM existence in more places before cloning * Set $env:LcmRootDir after finding or cloning LibLCM
* Persist LcmRootDir * Set FEEDBACK=off to prevent developers from sending prod analytics
papeh
force-pushed
the
feature/polish-lcm-clone
branch
from
August 18, 2026 16:34
637cd7b to
5ae26be
Compare
NUnit Tests 1 files 1 suites 10m 19s ⏱️ Results for commit 3a9904f. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=========================================
+ Coverage 0 38.26% +38.26%
=========================================
Files 0 1499 +1499
Lines 0 350229 +350229
Branches 0 40256 +40256
=========================================
+ Hits 0 134014 +134014
- Misses 0 186994 +186994
- Partials 0 29221 +29221 🚀 New features to boost your workflow:
|
* Move PATH refresh to the PATH region * Remove empty Verification region
* Set global env var only if it exists and points to a folder * Test $localizationsPath only if not $isWorktree * Update Setup-InstallerBuild and MD to recognize $env:LcmRootDir
Test for the liblcm path that the build will use, even if it doesn't exist. This reverts commit e5c95a5.
papeh
marked this pull request as ready for review
August 19, 2026 16:56
thejambi
approved these changes
Aug 19, 2026
thejambi
left a comment
thejambi
left a comment
Contributor
There was a problem hiding this comment.
@thejambi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).build.ps1/test.ps1or MSBuild).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is