Skip to content

Clean up PCPATR Preparer a little - #1055

Merged
AndyBlack merged 2 commits into
mainfrom
feature/clean-up-pcpatr
Aug 12, 2026
Merged

Clean up PCPATR Preparer a little#1055
AndyBlack merged 2 commits into
mainfrom
feature/clean-up-pcpatr

Conversation

@papeh

@papeh papeh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
  • Capture newly-created ICmPossibilityLists directly when created to simplify logic and prevent race condition interceptions (none proven or even likely)
  • Remove unused usings
  • Make Cache and ShowMessages properties readonly

Quick Summary

There is a problem with the cache not getting updated immediately when these lists are created. I don't expect these changes to fix this problem, but I can't imagine them doing any harm, and they remove a theoretical possibility of interference.

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

This change is Reviewable

papeh added 2 commits August 11, 2026 14:35
* Capture newly-created ICmPossibilityLists directly when created
to simplify logic and prevent race condition interceptions
(none proven)
* Remove unused usings
* Make Cache and ShowMessages properties readonly
SmartGit is reluctant to compare files with lines over 10k characters.
@papeh
papeh requested a review from AndyBlack August 11, 2026 19:43
@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 2s ⏱️ +9s
5 761 tests ±0  5 680 ✅ ±0  81 💤 ±0  0 ❌ ±0 
5 770 runs  ±0  5 689 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit dbffd0c. ± Comparison against base commit 82bbefb.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.04%. Comparing base (82bbefb) to head (dbffd0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   38.01%   38.04%   +0.02%     
==========================================
  Files        1499     1499              
  Lines      349945   350096     +151     
  Branches    40229    40229              
==========================================
+ Hits       133048   133199     +151     
  Misses     187616   187616              
  Partials    29281    29281              
Files with missing lines Coverage Δ
Src/Utilities/pcpatrflex/PrepFLExDBDll/Preparer.cs 98.08% <100.00%> (+1.78%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndyBlack AndyBlack left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does not fix LT-22649, these are good changes to have. I approve them.

@AndyBlack
AndyBlack marked this pull request as ready for review August 12, 2026 17:16
@AndyBlack
AndyBlack merged commit b857373 into main Aug 12, 2026
6 checks passed
@AndyBlack
AndyBlack deleted the feature/clean-up-pcpatr branch August 12, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants