Migrate from nigiri-based regtest to arkade-regtest - #95
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThe change adds RegTest environment overrides, registers the ChangesRegtest E2E integration
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.env.regtest:
- Around line 4-21: Update the docker-compose configuration used by
UpDockerTestTask to reference FULMINE_IMAGE, ARKD_IMAGE, and ARKD_WALLET_IMAGE
through environment interpolation instead of the hard-coded image/build values,
and replace literal ARKD_* timing settings with the corresponding interpolated
variables. Remove any unused variables from .env.regtest only if they are not
consumed elsewhere.
- Around line 1-21: The regtest Docker startup does not load the variables or
pinned Fulmine image from .env.regtest. Update UpDockerTestTask and its compose
configuration to load .env.regtest (or copy it to .env/pass equivalent explicit
variables) and replace the Fulmine latest image with the pinned v0.3.15 image or
a digest, preserving the other regtest overrides.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ad7f8990-7dd8-41d4-91d6-e0ed80bd5a11
📒 Files selected for processing (3)
.env.regtest.gitmodulesregtest
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e.yml:
- Around line 12-13: Update the actions/checkout configuration in the reusable
workflow to set persist-credentials to false alongside submodules: true,
ensuring the checkout token is not retained for later PR-controlled steps.
- Around line 32-33: Update the “Start RegTest Environment” step invoking
regtest.mjs so it sets AUTOMINE_INTERVAL=0, disabling background mining while
preserving the existing startup command.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 762a88e0-0704-43e2-9f29-f66fc3e29d72
📒 Files selected for processing (2)
.github/workflows/e2e.ymlarkade/build.gradle.kts
Summary by CodeRabbit