Skip to content

Migrate from nigiri-based regtest to arkade-regtest - #95

Merged
shubertm merged 5 commits into
masterfrom
tests/regtest-setup
Aug 6, 2026
Merged

Migrate from nigiri-based regtest to arkade-regtest#95
shubertm merged 5 commits into
masterfrom
tests/regtest-setup

Conversation

@shubertm

@shubertm shubertm commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Added a local regtest environment for development and testing.
    • Included pinned service versions, shared timing settings, minimum VTXO configuration, and zero transaction fees.
    • Added streamlined tooling for starting, stopping, and managing the regtest environment.
  • Tests
    • Updated end-to-end tests to run against the new regtest environment.
    • Added automatic environment cleanup after test runs.
    • Simplified test execution by removing the previous container-based setup.

@shubertm
shubertm marked this pull request as draft August 5, 2026 20:37
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@shubertm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8b0da3f-a503-4476-9d57-69c7f4a7cf3c

📥 Commits

Reviewing files that changed from the base of the PR and between d06f3a8 and 35bca06.

📒 Files selected for processing (1)
  • .env.regtest
📝 Walkthrough

Walkthrough

The change adds RegTest environment overrides, registers the arkade-regtest repository as a Git submodule, and updates E2E execution to use RegTest instead of Docker-based setup.

Changes

Regtest E2E integration

Layer / File(s) Summary
Regtest repository and environment setup
.gitmodules, regtest, .env.regtest
The repository now tracks the arkade-regtest submodule and includes pinned service images, shared timing and amount settings, and zero Ark input and output fees.
RegTest E2E workflow
.github/workflows/e2e.yml, arkade/build.gradle.kts
The workflow checks out submodules, starts RegTest with Node.js 20, runs the standalone testE2E task, and always cleans up. Docker-based E2E task registrations and setup steps were removed.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

  • shubertm/arkade-kotlin#22: Replaces Docker-based integration-test tasks, setup logic, Compose configuration, and Dockerfiles with a submodule-based RegTest workflow.
  • shubertm/arkade-kotlin#23: Replaces Docker-based E2E tasks and workflow with the RegTest-based testE2E flow.

Poem

A rabbit checks out RegTest today,
Pinned images guide the way.
E2E hops through testE2E,
Cleanup follows carefully.
Docker steps now fade away.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the migration from the Nigiri-based regtest setup to the arkade-regtest submodule and workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.env.regtest:
- Around line 4-21: Update the docker-compose configuration used by
UpDockerTestTask to reference FULMINE_IMAGE, ARKD_IMAGE, and ARKD_WALLET_IMAGE
through environment interpolation instead of the hard-coded image/build values,
and replace literal ARKD_* timing settings with the corresponding interpolated
variables. Remove any unused variables from .env.regtest only if they are not
consumed elsewhere.
- Around line 1-21: The regtest Docker startup does not load the variables or
pinned Fulmine image from .env.regtest. Update UpDockerTestTask and its compose
configuration to load .env.regtest (or copy it to .env/pass equivalent explicit
variables) and replace the Fulmine latest image with the pinned v0.3.15 image or
a digest, preserving the other regtest overrides.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad7f8990-7dd8-41d4-91d6-e0ed80bd5a11

📥 Commits

Reviewing files that changed from the base of the PR and between 9b1ae5d and e83f63a.

📒 Files selected for processing (3)
  • .env.regtest
  • .gitmodules
  • regtest

Comment thread .env.regtest
Comment thread .env.regtest
@shubertm
shubertm marked this pull request as ready for review August 6, 2026 16:56

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e.yml:
- Around line 12-13: Update the actions/checkout configuration in the reusable
workflow to set persist-credentials to false alongside submodules: true,
ensuring the checkout token is not retained for later PR-controlled steps.
- Around line 32-33: Update the “Start RegTest Environment” step invoking
regtest.mjs so it sets AUTOMINE_INTERVAL=0, disabling background mining while
preserving the existing startup command.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 762a88e0-0704-43e2-9f29-f66fc3e29d72

📥 Commits

Reviewing files that changed from the base of the PR and between e83f63a and 5e59733.

📒 Files selected for processing (2)
  • .github/workflows/e2e.yml
  • arkade/build.gradle.kts

Comment thread .github/workflows/e2e.yml
Comment thread .github/workflows/e2e.yml
@shubertm
shubertm merged commit b5d457c into master Aug 6, 2026
1 check passed
@shubertm
shubertm deleted the tests/regtest-setup branch August 6, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant