Skip to content

feat: Encapsulate wallet descriptors - #94

Merged
shubertm merged 1 commit into
masterfrom
feature/descriptors
Aug 4, 2026
Merged

feat: Encapsulate wallet descriptors#94
shubertm merged 1 commit into
masterfrom
feature/descriptors

Conversation

@shubertm

@shubertm shubertm commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Closes #81

Summary by CodeRabbit

  • New Features
    • Added support for creating and parsing Bitcoin Taproot descriptors.
    • Accepts both raw public keys and tr(...) descriptor formats.
    • Supports encoding Taproot descriptors from x-only public keys.
  • Tests
    • Added coverage for parsing and encoding Taproot descriptors.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e6b2269e-74c5-4d24-a8d6-90e1efd4c4da

📥 Commits

Reviewing files that changed from the base of the PR and between 1a41887 and 1c6cbf3.

📒 Files selected for processing (2)
  • arkade/src/commonMain/kotlin/com/arkade/core/bitcoin/Descriptor.kt
  • arkade/src/commonTest/kotlin/com/arkade/core/bitcoin/DescriptorTest.kt

📝 Walkthrough

Walkthrough

The PR adds a Descriptor class for Taproot descriptors. It supports raw and tr(...)-wrapped strings, x-only public keys, encoding, missing-key validation, and automated tests.

Changes

Taproot descriptor support

Layer / File(s) Summary
Descriptor API and validation
arkade/src/commonMain/kotlin/com/arkade/core/bitcoin/Descriptor.kt, arkade/src/commonTest/kotlin/com/arkade/core/bitcoin/DescriptorTest.kt
The new Descriptor class parses raw and tr(...)-wrapped keys, accepts XonlyPublicKey values, encodes Taproot descriptors, validates missing keys, and includes decoding and encoding tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks each key with care,
Then wraps it in tr(...) there.
Raw or x-only, both paths align,
Taproot descriptors now encode fine.
Hop, hop—the tests confirm the line!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the addition of wallet descriptor encapsulation implemented by the new Descriptor class.
Linked Issues check ✅ Passed The changes implement wallet descriptor encapsulation through Descriptor parsing and Taproot encoding, matching issue #81.
Out of Scope Changes check ✅ Passed The changes are limited to the Descriptor implementation and focused tests, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shubertm

shubertm commented Aug 4, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@shubertm
shubertm merged commit 9b1ae5d into master Aug 4, 2026
3 of 4 checks passed
@shubertm
shubertm deleted the feature/descriptors branch August 4, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encapsulate wallet descriptors

1 participant