Skip to content

Validate external args before .cmd shims; harden ADO npm token temp file - #47

Merged
shmuelie merged 2 commits into
mainfrom
fix/34-shim-arg-validation
Aug 14, 2026
Merged

Validate external args before .cmd shims; harden ADO npm token temp file#47
shmuelie merged 2 commits into
mainfrom
fix/34-shim-arg-validation

Conversation

@shmuelie

Copy link
Copy Markdown
Owner

Fixes #34

Summary

  • Adds per-module validation before Copilot plugin/marketplace/MCP inputs reach the copilot CLI shim.
  • Adds VS Code wrapper validation for extension IDs, names, path-like inputs, and --goto shape; open paths now follow --.
  • Hardens Update-AdoNpmToken temporary .npmrc handling with Windows owner-only ACLs and overwrite-before-delete cleanup.

Validation

  • .�uild\Test-Modules.ps1
  • .�uild\Invoke-Tests.ps1 -Path tests\Shmuelie.Copilot.Tests.ps1
  • .�uild\Invoke-Tests.ps1 -Path tests\Shmuelie.Utilities.Tests.ps1
  • Test-PublicRepoContent not available in this shell

shmuelie and others added 2 commits August 14, 2026 10:20
Add allow-list and cmd metacharacter validation before forwarding plugin, marketplace, MCP, and VS Code wrapper inputs to .cmd shims.

Harden temporary ADO npm token files with owner-only ACLs on Windows and overwrite-before-delete cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 18be4b78-3a83-4cb1-8f77-0b837e1c3076
…ation

# Conflicts:
#	modules/Shmuelie.Copilot/CHANGELOG.md
#	tests/Shmuelie.Copilot.Tests.ps1
@shmuelie
shmuelie merged commit 741b294 into main Aug 14, 2026
1 check passed
@shmuelie
shmuelie deleted the fix/34-shim-arg-validation branch August 14, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate externally-influenced args before passing to .cmd shims (copilot/code/npm); harden ADO token temp file

1 participant