Fix crash for devices with no room support - #47
Open
qypea wants to merge 1 commit into
Open
Conversation
After a recent upgrade to homeassistant those of us with shark robots that don't support rooms have been getting crashes in this code. This fixes it for me at least. home-assistant/core#116670
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
@benaclejames keeping with the HA contribution guidelines, please don’t ping for reviews. This is on my radar and I’m aware of the impact (and have been aware of both since they came up respectively), but I haven’t had time to review yet. I apologize for the inconvenience. We only have a couple maintainers for this integration. If anyone else is interested in joining the maintainer team feel free to contact the repo owner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a recent upgrade to homeassistant those of us with shark robots that don't support rooms have been getting crashes in this code. This fixes it for me at least.
home-assistant/core#116670
Note that I don't have a vacuum with room support to test the opposite case. Probably want to test it with one before merging it.