Do not read past the end of the file being patched#92
Merged
Conversation
A hunk with no surrounding context is placed wherever its range claims it belongs, which may be beyond the end of the file, or before the start of it once an offset from an earlier hunk is taken into account. Applying such a patch read the input lines out of range, and the resulting std::out_of_range escaped as the diagnostic "**** vector". Clamp the guess into the file, so that a location is always somewhere the applier can write.
Fuzz can match a hunk whose trailing context runs past the end of the file, since that context is dropped rather than compared. Those lines were still written out from the input, reading it out of range, and the resulting std::out_of_range escaped as the diagnostic "**** vector". Skip context and removals which have no line left to consume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two different bugs where we could throw an exception