A node under a controller is handler-scoped too - #3
Closed
vamsikalagaturu wants to merge 0 commit into
Closed
Conversation
vamsikalagaturu
force-pushed
the
fix/id-under-controller
branch
from
August 15, 2026 17:30
e4ce4f8 to
ee395a0
Compare
vamsikalagaturu
temporarily deployed
to
github-pages
August 15, 2026 17:31 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-qualification matched a node whose namespace is exactly a handler, so
<handler>/<name>split by handler while<handler>/<controller>/<name>did not.That matters once the DSL hangs a controller's generated nodes under the controller (secorolab/motion-spec-dsl#fix-path-name-collision): the IRIs separate, the ids still collapse, and
node_by_idkeeps the first — one motion's velocity profile disappeared from the IR without a word.Matching anywhere below the handler. All nine models regenerate with identical IR ids.